New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 620897 link

Starred by 2 users
Status: Assigned
Owner:
█ mikec...@chromium.org
Last visit > 30 days ago
Cc:
█ yolandyan@chromium.org
jbudorick@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make Robolectric's and Espresso's dependencies one version

Project Member Reported by yolandyan@chromium.org, Jun 16 2016 
Steps:
 - Upgrade junit to 4.12
 - Upgrade Mockito to latest beta
 - Delete jarjar

Comment 1 by mikec...@chromium.org, Jun 17 2016 

Mockito no longer the jars it depends on included in its git repo. To upgrade Mockito, we will have to add...

byte-buddy-1.3.16.jar
objenesis-2.1.jar

to third_party Chromium. Byte-buddy appears to depend on findbugs annotations which I believe is already under third_party/findbugs

Comment 2 by mikec...@chromium.org, Jun 17 2016 

Lol, idk how I screwed up that sentence so badly.

"Mockito no longer includes the jars that it depends on in its git repo"
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/716a8b1702dba88543ad9f1030bb0d4d7254a211

commit 716a8b1702dba88543ad9f1030bb0d4d7254a211
Author: yolandyan <yolandyan@chromium.org>
Date: Sat Jun 18 00:22:39 2016

Delete jarjar - no longer used anywere

BUG=620897

Review-Url: https://codereview.chromium.org/2072873003
Cr-Commit-Position: refs/heads/master@{#400549}

[modify] https://crrev.com/716a8b1702dba88543ad9f1030bb0d4d7254a211/DEPS
[modify] https://crrev.com/716a8b1702dba88543ad9f1030bb0d4d7254a211/tools/licenses.py

Comment 6 by shimazu@chromium.org, Aug 12 2016 

I'm trying `gclient sync` on the ToT now, but it was stuck for 30 min on here and said timeout:

________ running '/usr/bin/python src/build/android/update_deps/update_third_party_deps.py download -b chromium-byte-buddy -l third_party/byte_buddy' in ...

and after I tried reverting https://crrev.com/2226863002, it's also stuck at:

________ running '/usr/bin/python src/build/android/update_deps/update_third_party_deps.py download -b chromium-objenesis -l third_party/objenesis' in ...


Sorry in advance if it's only for me; I'm still not sure if this is just my problem.

Comment 7 by shimazu@chromium.org, Aug 12 2016 

Ah, sorry. Rebooting solves everything;)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5d3a70e2b63a9714e275b0e28960e349312b0d2

commit d5d3a70e2b63a9714e275b0e28960e349312b0d2
Author: mikecase <mikecase@chromium.org>
Date: Fri Aug 19 18:27:25 2016

Changes to update Junit and Mockito.

Updating Junit from 4.10 to 4.12
Updating Mockito from 1.10.5 to 2.0.99-beta

This change is mostly motivated to make it so we only have 1
version of third_party libraries in Chromium. Junit 4.12,
Mockito 2.0.99-beta, and Espresso and Robolectric 3.0 all
depend on Hamcrest 1.3. Some build errors occur when building
Espresso tests currently due to multiple versions of Hamcrest
in the dependency tree.

Additionally, its just nice to update these libraries since they
are several years old.

BUG=620897

Review-Url: https://codereview.chromium.org/2076783004
Cr-Commit-Position: refs/heads/master@{#413191}

[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/DEPS
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/BUILD.gn
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtilsTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteControllerTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterTestBase.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/CastMessageHandlerTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/DiscoveryCallbackTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/JSONTestUtils.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/junit/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderUnitTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/HostBrowserClassLoaderTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/components/policy/android/BUILD.gn
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/components/policy/android/junit/src/org/chromium/policy/AbstractAppRestrictionsProviderTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/components/policy/android/junit/src/org/chromium/policy/CombinedPolicyProviderTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/components/policy/android/junit/src/org/chromium/policy/test/annotations/PoliciesTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/components/web_restrictions/BUILD.gn
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/browser/WebRestrictionsClientTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/browser/WebRestrictionsContentProviderTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/net/android/BUILD.gn
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/net/android/junit/src/org/chromium/net/HttpNegotiateAuthenticatorTest.java
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/third_party/hamcrest/BUILD.gn
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/third_party/junit/BUILD.gn
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/third_party/junit/OWNERS
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/third_party/junit/README.chromium
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/third_party/mockito/BUILD.gn
[modify] https://crrev.com/d5d3a70e2b63a9714e275b0e28960e349312b0d2/third_party/mockito/README.chromium

Comment 9 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment