New issue
Advanced search Search tips

Issue 620878 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove guards against using API introduced in iOS10 SDK.

Project Member Reported by michaeldo@chromium.org, Jun 16 2016

Issue description

Cleanup guards around using iOS10 SDK functionality once moved to iOS10 SDK.
 
Labels: Proj-iOS10
Owner: michaeldo@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d60b92115599fb6a2a81175d08daed171414bcdd

commit d60b92115599fb6a2a81175d08daed171414bcdd
Author: michaeldo <michaeldo@chromium.org>
Date: Wed Nov 16 00:08:44 2016

Remove all enabled data detectors.

Due to the failures seen with the calendarEvent data detector and
potential undiscovered failures of the flight number data detector, both
data detectors will be removed.

BUG= 620878 ,662962

Review-Url: https://codereview.chromium.org/2503033003
Cr-Commit-Position: refs/heads/master@{#432301}

[modify] https://crrev.com/d60b92115599fb6a2a81175d08daed171414bcdd/ios/web/web_state/ui/wk_web_view_configuration_provider.mm

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2016

Labels: merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c938d8b4dbc9302aa95942bca1760ba4706e93dd

commit c938d8b4dbc9302aa95942bca1760ba4706e93dd
Author: Eugene But <eugenebut@google.com>
Date: Mon Nov 21 23:11:48 2016

Remove all enabled data detectors.

Due to the failures seen with the calendarEvent data detector and
potential undiscovered failures of the flight number data detector, both
data detectors will be removed.

BUG= 620878 ,662962

Review-Url: https://codereview.chromium.org/2503033003
Cr-Commit-Position: refs/heads/master@{#432301}
(cherry picked from commit d60b92115599fb6a2a81175d08daed171414bcdd)

Review URL: https://codereview.chromium.org/2525463002 .

Cr-Commit-Position: refs/branch-heads/2883@{#637}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/c938d8b4dbc9302aa95942bca1760ba4706e93dd/ios/web/web_state/ui/wk_web_view_configuration_provider.mm

Sign in to add a comment