Use WebSafe Base64 encoding when sending requests to PVer4 SafeBrowsing server. |
|||
Issue descriptionUse WebSafe Base64 encoding when sending requests to PVer4 SafeBrowsing server. The web safe encoding is defined here: https://tools.ietf.org/html/rfc3548#section-4 The server doesn't understand basic base64 encoding. Confirmed by awoz. This hash fails: GiIIARACGhoKDQgBEAYYASIDMDAxMAEQ00EaAhgKW+JBOSgB This one works: GiIIARACGhoKDQgBEAYYASIDMDAxMAEQ00EaAhgKW-JBOSgB
,
Jun 16 2016
FYI, I think this is the latest RFC reference: https://tools.ietf.org/html/rfc4648#page-7
,
Jun 16 2016
See base/base64url.h
,
Jun 16 2016
Luckily, I don't need to solve this problem. It is available at: https://cs.chromium.org/chromium/src/base/base64url.h?sq=package:chromium&dr=CSs&rcl=1466090357&l=30
,
Jun 16 2016
mattm@ -- you beat me by seconds. Thanks for pointing it out.
,
Jun 17 2016
,
Jun 21 2016
awoz@ -- can you please tell us which Base64UrlEncodePolicy to use? https://cs.chromium.org/chromium/src/base/base64url.h?sq=package:chromium&dr=CSs&rcl=1466090357&l=17 FWIW: There are more instances of usage of INCLUDE_PADDING in Chromium than OMIT_PADDING.
,
Jun 22 2016
Our server accepts payloads with padding.
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/902ddfefc285ceef7284d907b6a5611ebb9852e4 commit 902ddfefc285ceef7284d907b6a5611ebb9852e4 Author: vakh <vakh@chromium.org> Date: Wed Jun 29 04:27:04 2016 Use WebBase64/UrlBase64 encoding for requests sent to the server. BUG= 543161 , 620874 Review-Url: https://codereview.chromium.org/2090593003 Cr-Commit-Position: refs/heads/master@{#402715} [modify] https://crrev.com/902ddfefc285ceef7284d907b6a5611ebb9852e4/components/safe_browsing_db/v4_get_hash_protocol_manager.cc [modify] https://crrev.com/902ddfefc285ceef7284d907b6a5611ebb9852e4/components/safe_browsing_db/v4_update_protocol_manager.cc [modify] https://crrev.com/902ddfefc285ceef7284d907b6a5611ebb9852e4/components/safe_browsing_db/v4_update_protocol_manager.h [modify] https://crrev.com/902ddfefc285ceef7284d907b6a5611ebb9852e4/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc
,
Jun 29 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vakh@chromium.org
, Jun 16 2016