New issue
Advanced search Search tips

Issue 620855 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove redundant copy of native_blob.bin

Project Member Reported by michaelbai@chromium.org, Jun 16 2016

Issue description

64-bit and 32-bit native_blob.bin are actually same now, we should remove the redundant copy from 64-bit Monochrome and WebView APK.
 

Comment 1 by torne@chromium.org, Jun 17 2016

Was this an intentional change in V8 and it's guaranteed to always be the case now? If you don't know this for sure, we should check with them first...
I checked with them, yangguo@ (cc-ed) confirmed.

Comment 3 by torne@chromium.org, Jun 17 2016

OK, great! We can just remove the per-architecture generation and special-casing so that it goes back to just having the same name on both, and then the APK merging script will verify they're the same.
No, only native_blob.bin is same, snapshot-blob.bin is still different

Comment 5 by torne@chromium.org, Jun 17 2016

Yes, I meant for native_blob.bin specifically.
Yes. natives_blob.bin is just a serialized form of the minified js scripts that V8 uses to implement some built-ins. Its format and content is independent of the platform.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/53490c73354424618b73526b8a5032bf39786773

commit 53490c73354424618b73526b8a5032bf39786773
Author: Tao Bai <michaelbai@google.com>
Date: Mon Jun 20 21:18:26 2016

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dc223a1b405951f7deec0fc8de076a0b4ec2d6c

commit 5dc223a1b405951f7deec0fc8de076a0b4ec2d6c
Author: michaelbai <michaelbai@chromium.org>
Date: Thu Jun 23 22:03:25 2016

Move v8 snapshot renaming code to v8/BUILD.gn

BUG= 620855 

Review-Url: https://codereview.chromium.org/2088973002
Cr-Commit-Position: refs/heads/master@{#401739}

[modify] https://crrev.com/5dc223a1b405951f7deec0fc8de076a0b4ec2d6c/build_overrides/v8.gni

Status: Fixed (was: Assigned)

Sign in to add a comment