Remove redundant copy of native_blob.bin |
||
Issue description64-bit and 32-bit native_blob.bin are actually same now, we should remove the redundant copy from 64-bit Monochrome and WebView APK.
,
Jun 17 2016
I checked with them, yangguo@ (cc-ed) confirmed.
,
Jun 17 2016
OK, great! We can just remove the per-architecture generation and special-casing so that it goes back to just having the same name on both, and then the APK merging script will verify they're the same.
,
Jun 17 2016
No, only native_blob.bin is same, snapshot-blob.bin is still different
,
Jun 17 2016
Yes, I meant for native_blob.bin specifically.
,
Jun 17 2016
Yes. natives_blob.bin is just a serialized form of the minified js scripts that V8 uses to implement some built-ins. Its format and content is independent of the platform.
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/020375884deec1236a187f5b4c0a20cf5d30ce4e commit 020375884deec1236a187f5b4c0a20cf5d30ce4e Author: michaelbai <michaelbai@chromium.org> Date: Tue Jun 21 16:08:15 2016 Remove natives_blob.bin's arch dependence. This is first patch which keeps renaming logical in gn, but didn't rename natives_blob.bin to arch specific name, so the v8 patch (https://codereview.chromium.org/2074283002/) could be landed afterwards without breaking anything. BUG= 620855 Review-Url: https://codereview.chromium.org/2075283003 Cr-Commit-Position: refs/heads/master@{#401005} [modify] https://crrev.com/020375884deec1236a187f5b4c0a20cf5d30ce4e/android_webview/lib/main/aw_main_delegate.cc [modify] https://crrev.com/020375884deec1236a187f5b4c0a20cf5d30ce4e/build_overrides/v8.gni [modify] https://crrev.com/020375884deec1236a187f5b4c0a20cf5d30ce4e/content/app/content_main_runner.cc [modify] https://crrev.com/020375884deec1236a187f5b4c0a20cf5d30ce4e/content/browser/child_process_launcher.cc [modify] https://crrev.com/020375884deec1236a187f5b4c0a20cf5d30ce4e/content/public/common/content_descriptors.h [modify] https://crrev.com/020375884deec1236a187f5b4c0a20cf5d30ce4e/gin/v8_initializer.cc [modify] https://crrev.com/020375884deec1236a187f5b4c0a20cf5d30ce4e/gin/v8_initializer.h
,
Jun 21 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/53490c73354424618b73526b8a5032bf39786773 commit 53490c73354424618b73526b8a5032bf39786773 Author: Tao Bai <michaelbai@google.com> Date: Mon Jun 20 21:18:26 2016
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dc223a1b405951f7deec0fc8de076a0b4ec2d6c commit 5dc223a1b405951f7deec0fc8de076a0b4ec2d6c Author: michaelbai <michaelbai@chromium.org> Date: Thu Jun 23 22:03:25 2016 Move v8 snapshot renaming code to v8/BUILD.gn BUG= 620855 Review-Url: https://codereview.chromium.org/2088973002 Cr-Commit-Position: refs/heads/master@{#401739} [modify] https://crrev.com/5dc223a1b405951f7deec0fc8de076a0b4ec2d6c/build_overrides/v8.gni
,
Jul 7 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by torne@chromium.org
, Jun 17 2016