Mojo C++ bindings should use base::Callback. The longer we have mojo::Callback available, the harder it will be to remove. So this should be done ASAP.
Issue 596521 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c383dde80197ffd21e23d89eddf0b7a4d819a3de commit c383dde80197ffd21e23d89eddf0b7a4d819a3de Author: rockot <rockot@chromium.org> Date: Sat Jun 18 20:15:51 2016 mojo::Callback -> base::Callback Replaces mojo::Callback with base::Callback. This means updating several callback sites for the following reasons: - The mojo::Callback<T>::Runnable interface no longer exists - C++11 lambas may no longer be bound implicitly - Repsonse callback signatures must now match the generated signature exactly (i.e. no implicit conversion from const mojo::String& or const std::string& to a by-value mojo::String) - Null mojo::Callbacks could be Run without crashing; this is no longer true. - It's base::Callback::Reset instead of mojo::Callback::reset mojo::Callback and mojo::Closure are left in place as aliases for base::Callback and base::Closure until all references can be updated. BUG= 620840 TBR=ben@chromium.org for general/toplevel TBR=xhwang@chromium.org for media related changes Review-Url: https://codereview.chromium.org/2062333002 Cr-Commit-Position: refs/heads/master@{#400598} [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/chrome/browser/chromeos/arc/arc_auth_service.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/chrome/browser/media/router/mojo/media_router_mojo_impl.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/chrome/browser/media/router/mojo/media_router_mojo_impl.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/chrome/browser/ui/android/usb_chooser_dialog_android.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/chrome/browser/usb/usb_chooser_controller.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/chrome/renderer/chrome_render_thread_observer.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/components/arc/arc_bridge_service.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/components/arc/arc_bridge_service.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/components/autofill/content/public/cpp/autofill_types_struct_traits_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/components/filesystem/files_test_base.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/components/leveldb/leveldb_service_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/components/leveldb/remote_iterator_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/components/mus/gles2/command_buffer_impl.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/components/mus/public/cpp/lib/command_buffer_client_impl.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/components/mus/public/cpp/lib/window_tree_client.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/components/safe_json/safe_json_parser_impl.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/components/safe_json/safe_json_parser_impl.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/content/browser/background_sync/background_sync_service_impl_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/content/browser/battery_status/battery_monitor_integration_browsertest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/content/browser/geolocation/geolocation_service_impl.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/content/browser/permissions/permission_service_impl.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/content/browser/presentation/presentation_service_impl.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/content/browser/renderer_host/render_process_host_browsertest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/content/child/background_sync/background_sync_provider.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/content/child/background_sync/background_sync_provider.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/content/child/permissions/permission_dispatcher.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/content/child/permissions/permission_dispatcher.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/content/renderer/render_frame_impl.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/device/battery/battery_monitor_impl.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/device/usb/mojo/device_manager_impl.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mash/app_driver/app_driver.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mash/app_driver/app_driver.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/media/capture/video/fake_video_capture_device_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/media/capture/video/scoped_result_callback.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/media/mojo/services/mojo_cdm_promise.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/media/mojo/services/mojo_provision_fetcher.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/media/mojo/services/mojo_provision_fetcher.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/common/common_custom_types_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/mojo_edk_tests.gyp [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/mojo_public.gypi [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/BUILD.gn [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/associated_binding.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/binding_set.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/callback.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/interface_ptr_set.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/lib/binding_state.h [delete] https://crrev.com/a594f58db3c8c7a46cec24b4b7669041171ebb2a/mojo/public/cpp/bindings/lib/callback_internal.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/lib/connector.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/lib/control_message_proxy.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/lib/interface_ptr_state.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/lib/multiplex_router.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/lib/router.cc [delete] https://crrev.com/a594f58db3c8c7a46cec24b4b7669041171ebb2a/mojo/public/cpp/bindings/lib/shared_data.h [delete] https://crrev.com/a594f58db3c8c7a46cec24b4b7669041171ebb2a/mojo/public/cpp/bindings/lib/shared_ptr.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/strong_binding.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/BUILD.gn [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/associated_interface_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/binding_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/bindings_perftest.cc [delete] https://crrev.com/a594f58db3c8c7a46cec24b4b7669041171ebb2a/mojo/public/cpp/bindings/tests/callback_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/connector_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/e2e_perftest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/pickle_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/request_response_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/router_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/struct_traits_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/sync_method_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/union_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/cpp/bindings/tests/wtf_types_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/services/shell/background/tests/background_shell_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/services/shell/public/cpp/lib/connection_impl.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/services/shell/public/cpp/lib/connection_impl.h [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/services/shell/public/cpp/lib/shell_connection.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/services/shell/shell.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/services/shell/tests/connect/connect_test_app.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/services/shell/tests/connect/connect_unittest.cc [modify] https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef commit 3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef Author: rockot <rockot@chromium.org> Date: Sun Jun 19 09:08:54 2016 Deletes mojo::Callback Removes all references to mojo::Callback and mojo::Closure, replacing them with base::Callback or base::Closure, or where applicable a mojom-generated callback alias. The vast majority of the changes here are name changes only, as mojo::Callback is already an alias for base::Callback. Hence the TBRs. Also removes mojo/public/cpp/bindings/callback.h BUG= 620840 TBR=ben@chromium.org for chrome, content, misc TBR=lhchavez@chromium.org for components/arc TBR=xhwang@chromium.org for media TBR=haraken@chromium.org for third_party/WebKit Review-Url: https://codereview.chromium.org/2080513002 Cr-Commit-Position: refs/heads/master@{#400616} [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/chrome/renderer/chrome_render_thread_observer.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/chrome/utility/image_decoder_impl.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/chrome/utility/image_decoder_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/arc/bluetooth/arc_bluetooth_bridge.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/arc/bluetooth/arc_bluetooth_bridge.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/arc/obb_mounter/arc_obb_mounter_bridge.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/bitmap_uploader/bitmap_uploader.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/filesystem/directory_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/font_service/BUILD.gn [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/mus/clipboard/BUILD.gn [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/mus/clipboard/clipboard_impl.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/mus/public/cpp/lib/window_surface.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/mus/public/cpp/window_surface.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/mus/ws/BUILD.gn [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/mus/ws/platform_display.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/mus/ws/server_window_surface.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/mus/ws/window_tree.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/mus/ws/window_tree.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/components/mus/ws/window_tree_client_unittest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/browser/battery_status/battery_monitor_integration_browsertest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/browser/geolocation/geolocation_service_impl.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/browser/geolocation/geolocation_service_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/browser/media/capture/image_capture_impl.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/browser/permissions/permission_service_impl.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/browser/permissions/permission_service_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/browser/presentation/presentation_service_impl.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/browser/presentation/presentation_service_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/browser/presentation/presentation_service_impl_unittest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/browser/webui/web_ui_mojo_browsertest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/renderer/background_sync/background_sync_client_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/renderer/render_thread_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/battery/battery_monitor_impl.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/battery/battery_monitor_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/serial/data_sink_receiver.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/serial/data_sink_receiver.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/serial/serial_connection.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/serial/serial_connection.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/serial/serial_service_impl.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/serial/serial_service_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/usb/mojo/BUILD.gn [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/usb/mojo/device_impl.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/usb/mojo/device_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/device/usb/mojo/device_manager_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/extensions/browser/api/mime_handler_private/mime_handler_private.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/extensions/browser/api/mime_handler_private/mime_handler_private.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/extensions/browser/mojo/stash_backend.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/ipc/mojo/ipc_mojo_bootstrap.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/media/capture/video/scoped_result_callback.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/media/capture/video/video_capture_device.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/media/mojo/services/mojo_cdm_promise.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/media/mojo/services/mojo_cdm_service.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/media/mojo/services/mojo_cdm_service.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/media/mojo/services/mojo_decryptor_service.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/media/mojo/services/mojo_decryptor_service.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/media/mojo/services/mojo_renderer_service.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/media/mojo/services/mojo_renderer_service.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/mojo_public.gypi [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/BUILD.gn [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/associated_binding.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/associated_interface_ptr.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/binding.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/binding_set.h [delete] https://crrev.com/61fdb768d7395fbb73daff12d9b38100df6a044f/mojo/public/cpp/bindings/callback.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/interface_ptr.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/lib/binding_state.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/lib/connector.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/lib/control_message_proxy.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/lib/control_message_proxy.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/lib/interface_endpoint_client.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/lib/interface_ptr_state.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/lib/multiplex_router.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/lib/router.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/lib/validation_errors.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/lib/validation_errors.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/strong_binding.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/tests/BUILD.gn [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/tests/associated_interface_unittest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/tests/bindings_perftest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/tests/connector_unittest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/tests/request_response_unittest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/cpp/bindings/tests/sync_method_unittest.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/net/proxy/proxy_resolver_factory_mojo.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/services/shell/public/cpp/connection.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/services/shell/public/cpp/lib/connection_impl.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/services/shell/public/cpp/lib/connection_impl.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/services/shell/public/cpp/shell_connection.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/services/user/user_shell_client.cc [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/services/user/user_shell_client.h [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/third_party/WebKit/Source/platform/mojo/DEPS [modify] https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef/third_party/WebKit/Source/platform/mojo/MojoHelper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f66fe7e469c66fcad8344d669f0f31f11165ff03 commit f66fe7e469c66fcad8344d669f0f31f11165ff03 Author: yutak <yutak@chromium.org> Date: Sun Jun 19 09:24:36 2016 Revert of Deletes mojo::Callback (patchset #2 id:20001 of https://codereview.chromium.org/2080513002/ ) Reason for revert: Caused compile errors. https://build.chromium.org/p/chromium.perf/builders/Android%20Builder/builds/91059 Sounds like this raced with the following change: https://chromium.googlesource.com/chromium/src/+/61fdb768d7395fbb73daff12d9b38100df6a044f Original issue's description: > Deletes mojo::Callback > > Removes all references to mojo::Callback and mojo::Closure, > replacing them with base::Callback or base::Closure, or > where applicable a mojom-generated callback alias. > > The vast majority of the changes here are name changes only, > as mojo::Callback is already an alias for base::Callback. > Hence the TBRs. > > Also removes mojo/public/cpp/bindings/callback.h > > BUG= 620840 > TBR=ben@chromium.org for chrome, content, misc > TBR=lhchavez@chromium.org for components/arc > TBR=xhwang@chromium.org for media > TBR=haraken@chromium.org for third_party/WebKit > > Committed: https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef > Cr-Commit-Position: refs/heads/master@{#400616} TBR=rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 620840 Review-Url: https://codereview.chromium.org/2080083002 Cr-Commit-Position: refs/heads/master@{#400617} [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/chrome/renderer/chrome_render_thread_observer.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/chrome/utility/image_decoder_impl.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/chrome/utility/image_decoder_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/arc/bluetooth/arc_bluetooth_bridge.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/arc/bluetooth/arc_bluetooth_bridge.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/arc/obb_mounter/arc_obb_mounter_bridge.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/bitmap_uploader/bitmap_uploader.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/filesystem/directory_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/font_service/BUILD.gn [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/mus/clipboard/BUILD.gn [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/mus/clipboard/clipboard_impl.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/mus/public/cpp/lib/window_surface.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/mus/public/cpp/window_surface.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/mus/ws/BUILD.gn [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/mus/ws/platform_display.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/mus/ws/server_window_surface.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/mus/ws/window_tree.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/mus/ws/window_tree.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/components/mus/ws/window_tree_client_unittest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/browser/battery_status/battery_monitor_integration_browsertest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/browser/geolocation/geolocation_service_impl.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/browser/geolocation/geolocation_service_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/browser/media/capture/image_capture_impl.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/browser/permissions/permission_service_impl.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/browser/permissions/permission_service_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/browser/presentation/presentation_service_impl.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/browser/presentation/presentation_service_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/browser/presentation/presentation_service_impl_unittest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/browser/webui/web_ui_mojo_browsertest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/renderer/background_sync/background_sync_client_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/renderer/render_thread_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/battery/battery_monitor_impl.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/battery/battery_monitor_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/serial/data_sink_receiver.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/serial/data_sink_receiver.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/serial/serial_connection.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/serial/serial_connection.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/serial/serial_service_impl.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/serial/serial_service_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/usb/mojo/BUILD.gn [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/usb/mojo/device_impl.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/usb/mojo/device_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/device/usb/mojo/device_manager_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/extensions/browser/api/mime_handler_private/mime_handler_private.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/extensions/browser/api/mime_handler_private/mime_handler_private.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/extensions/browser/mojo/stash_backend.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/ipc/mojo/ipc_mojo_bootstrap.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/media/capture/video/scoped_result_callback.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/media/capture/video/video_capture_device.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/media/mojo/services/mojo_cdm_promise.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/media/mojo/services/mojo_cdm_service.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/media/mojo/services/mojo_cdm_service.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/media/mojo/services/mojo_decryptor_service.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/media/mojo/services/mojo_decryptor_service.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/media/mojo/services/mojo_renderer_service.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/media/mojo/services/mojo_renderer_service.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/mojo_public.gypi [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/BUILD.gn [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/associated_binding.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/associated_interface_ptr.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/binding.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/binding_set.h [add] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/callback.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/interface_ptr.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/lib/binding_state.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/lib/connector.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/lib/control_message_proxy.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/lib/control_message_proxy.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/lib/interface_endpoint_client.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/lib/interface_ptr_state.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/lib/multiplex_router.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/lib/router.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/lib/validation_errors.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/lib/validation_errors.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/strong_binding.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/tests/BUILD.gn [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/tests/associated_interface_unittest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/tests/bindings_perftest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/tests/connector_unittest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/tests/request_response_unittest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/cpp/bindings/tests/sync_method_unittest.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/net/proxy/proxy_resolver_factory_mojo.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/services/shell/public/cpp/connection.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/services/shell/public/cpp/lib/connection_impl.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/services/shell/public/cpp/lib/connection_impl.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/services/shell/public/cpp/shell_connection.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/services/user/user_shell_client.cc [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/services/user/user_shell_client.h [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/third_party/WebKit/Source/platform/mojo/DEPS [modify] https://crrev.com/f66fe7e469c66fcad8344d669f0f31f11165ff03/third_party/WebKit/Source/platform/mojo/MojoHelper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a21316a36e7774327b4f05f62be2f9eda35e7c99 commit a21316a36e7774327b4f05f62be2f9eda35e7c99 Author: rockot <rockot@chromium.org> Date: Sun Jun 19 17:08:36 2016 Deletes mojo::Callback Removes all references to mojo::Callback and mojo::Closure, replacing them with base::Callback or base::Closure, or where applicable a mojom-generated callback alias. The vast majority of the changes here are name changes only, as mojo::Callback is already an alias for base::Callback. Hence the TBRs. Also removes mojo/public/cpp/bindings/callback.h BUG= 620840 TBR=ben@chromium.org for chrome, content, misc TBR=lhchavez@chromium.org for components/arc TBR=xhwang@chromium.org for media TBR=haraken@chromium.org for third_party/WebKit Committed: https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef Review-Url: https://codereview.chromium.org/2080513002 Cr-Original-Commit-Position: refs/heads/master@{#400616} Cr-Commit-Position: refs/heads/master@{#400620} [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/chrome/renderer/chrome_render_thread_observer.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/chrome/utility/image_decoder_impl.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/chrome/utility/image_decoder_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/arc/bluetooth/arc_bluetooth_bridge.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/arc/bluetooth/arc_bluetooth_bridge.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/arc/obb_mounter/arc_obb_mounter_bridge.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/bitmap_uploader/bitmap_uploader.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/filesystem/directory_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/font_service/BUILD.gn [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/mus/clipboard/BUILD.gn [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/mus/clipboard/clipboard_impl.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/mus/public/cpp/lib/window_surface.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/mus/public/cpp/window_surface.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/mus/ws/BUILD.gn [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/mus/ws/platform_display.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/mus/ws/server_window_surface.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/mus/ws/window_tree.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/mus/ws/window_tree.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/components/mus/ws/window_tree_client_unittest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/browser/battery_status/battery_monitor_integration_browsertest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/browser/geolocation/geolocation_service_impl.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/browser/geolocation/geolocation_service_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/browser/media/capture/image_capture_impl.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/browser/permissions/permission_service_impl.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/browser/permissions/permission_service_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/browser/presentation/presentation_service_impl.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/browser/presentation/presentation_service_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/browser/presentation/presentation_service_impl_unittest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/browser/webui/web_ui_mojo_browsertest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/renderer/background_sync/background_sync_client_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/renderer/render_thread_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/battery/battery_monitor_impl.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/battery/battery_monitor_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/serial/data_sink_receiver.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/serial/data_sink_receiver.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/serial/serial_connection.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/serial/serial_connection.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/serial/serial_service_impl.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/serial/serial_service_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/usb/mojo/BUILD.gn [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/usb/mojo/device_impl.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/usb/mojo/device_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/device/usb/mojo/device_manager_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/extensions/browser/api/mime_handler_private/mime_handler_private.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/extensions/browser/api/mime_handler_private/mime_handler_private.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/extensions/browser/mojo/stash_backend.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/ipc/mojo/ipc_mojo_bootstrap.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/media/capture/video/scoped_result_callback.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/media/capture/video/video_capture_device.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/media/mojo/clients/mojo_demuxer_stream_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/media/mojo/services/mojo_cdm_promise.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/media/mojo/services/mojo_cdm_service.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/media/mojo/services/mojo_cdm_service.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/media/mojo/services/mojo_decryptor_service.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/media/mojo/services/mojo_decryptor_service.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/media/mojo/services/mojo_renderer_service.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/media/mojo/services/mojo_renderer_service.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/mojo_public.gypi [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/BUILD.gn [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/associated_binding.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/associated_interface_ptr.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/binding.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/binding_set.h [delete] https://crrev.com/9e60626f1eff0762824242bd6513faf9712e999b/mojo/public/cpp/bindings/callback.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/interface_ptr.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/lib/binding_state.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/lib/connector.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/lib/control_message_proxy.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/lib/control_message_proxy.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/lib/interface_endpoint_client.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/lib/interface_ptr_state.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/lib/multiplex_router.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/lib/router.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/lib/validation_errors.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/lib/validation_errors.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/strong_binding.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/tests/BUILD.gn [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/tests/associated_interface_unittest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/tests/bindings_perftest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/tests/connector_unittest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/tests/request_response_unittest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/cpp/bindings/tests/sync_method_unittest.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/net/proxy/proxy_resolver_factory_mojo.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/services/shell/public/cpp/connection.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/services/shell/public/cpp/lib/connection_impl.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/services/shell/public/cpp/lib/connection_impl.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/services/shell/public/cpp/shell_connection.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/services/user/user_shell_client.cc [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/services/user/user_shell_client.h [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/third_party/WebKit/Source/platform/mojo/DEPS [modify] https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99/third_party/WebKit/Source/platform/mojo/MojoHelper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97aa5fec3372fc8b658a007e095d614b91893622 commit 97aa5fec3372fc8b658a007e095d614b91893622 Author: erg <erg@chromium.org> Date: Mon Jun 20 21:34:57 2016 mojo: Re-allow empty callbacks to be passed to the bindings. mojo::Callback just ignored null callbacks. Transitioning to base::Callback, which crashes on null callbacks, caused crashes in some compositor components. BUG= 620840 Review-Url: https://codereview.chromium.org/2084703002 Cr-Commit-Position: refs/heads/master@{#400789} [modify] https://crrev.com/97aa5fec3372fc8b658a007e095d614b91893622/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl
Comment 1 by roc...@chromium.org
, Jun 18 2016