Update Chrome for Windows app icon |
|||
Issue descriptionCurrent app icon shown in Start Menu, etc. is too large. Assets here: https://drive.google.com/corp/drive/folders/0B9Rk2knI0XDlN0g3VEd3SzB0UkE Icon is transparent and should be given a pure white "backplate" as per https://msdn.microsoft.com/en-us/windows/uwp/controls-and-patterns/tiles-and-notifications-app-assets
,
Jun 17 2016
(As I mentioned in the other bug, I think we should do full-bleed with the correct chrome font too eventually, but we can't easily do that due to app shortcut icons needing to have custom titles.)
,
Jun 17 2016
Re comment 2: Correct.
,
Jun 17 2016
Man, VisualElements is such a disaster. ForegroundText isn't respected on Win10. So, we can't have dark text on Win10 without baking it in, it seems.
,
Jun 17 2016
It's sort of documented as such here: https://msdn.microsoft.com/en-us/library/windows/apps/dn423310.aspx . "This value is ignored. All tiles use the light text color." That note sort of looks like it's supposed to apply to only Phone, but it's clearly not taking effect on Win10 TH2 either. We also (!) can't specify "transparent" as the BG color (doing so causes the , so we can't match UWP apps). I looked a couple other apps that use VisualElementsManifest.xml. Dropbox hard codes it to #007EE5 which matches other things nicely... unless the user changes their accent colour which is new after TH2. Firefox picked a neutral grey. Edge also hardcodes to the fixed blue.
,
Jun 17 2016
"(doing so causes the ," should have been "(doing so causes the manifest to be ignored entirely, "
,
Jun 17 2016
Well, the background color is supposed to be white. The asset is just transparent because it seemed from the documentation (https://msdn.microsoft.com/en-us/windows/uwp/controls-and-patterns/tiles-and-notifications-app-assets) like that was what was necessary to trigger the non-full-bleed tile UI. But if we can't set dark foreground text, we might need to use the full-bleed tile UI anyway. That runs into a problem with Chrome Apps using the same icon, you said, right?
,
Jun 17 2016
> But if we can't set dark foreground text, we might need to use the full-bleed tile UI anyway. That runs into a problem with Chrome Apps using the same icon, you said, right? That's right. We'd have to do #3 here https://bugs.chromium.org/p/chromium/issues/detail?id=571230#c25 which is a large-ish undertaking (or at least a lot bigger than subbing in some new art).
,
Jun 17 2016
Re your comment here: https://bugs.chromium.org/p/chromium/issues/detail?id=571230#c26 Does the issue with Chrome Apps inheriting Chrome's icon actually make a difference for what Chrome's icon should be? Either way, all Chrome Apps have a "bunch of indistinguishable icons," no?
,
Jun 17 2016
Never mind, I realize what you mean - these full-bleed tiles would also lack app name text, so they'd really be indistinguishable. Given all this, let's use the same non-full-bleed icon but on a dark background. I'll get back to you with a value.
,
Jun 17 2016
All right, how about setting #212121 as the background color? I'd expect something like this.
,
Jun 17 2016
CL here with new assets and #212121: https://codereview.chromium.org/2073123003
,
Jun 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfe436f54ef0d0c9740bc1f6b68fa8bf34eaabe2 commit bfe436f54ef0d0c9740bc1f6b68fa8bf34eaabe2 Author: scottmg <scottmg@chromium.org> Date: Mon Jun 20 22:04:08 2016 Update Windows start menu art R=grt@chromium.org BUG= 620817 Review-Url: https://codereview.chromium.org/2073123003 Cr-Commit-Position: refs/heads/master@{#400804} [modify] https://crrev.com/bfe436f54ef0d0c9740bc1f6b68fa8bf34eaabe2/chrome/installer/setup/install.cc [modify] https://crrev.com/bfe436f54ef0d0c9740bc1f6b68fa8bf34eaabe2/chrome/installer/setup/install_unittest.cc [modify] https://crrev.com/bfe436f54ef0d0c9740bc1f6b68fa8bf34eaabe2/win8/resources/Logo.png [modify] https://crrev.com/bfe436f54ef0d0c9740bc1f6b68fa8bf34eaabe2/win8/resources/SmallLogo.png [modify] https://crrev.com/bfe436f54ef0d0c9740bc1f6b68fa8bf34eaabe2/win8/resources/chrome.VisualElementsManifest.xml
,
Jun 20 2016
I'm going to call this fixed for now. We should revisit once we have a solution for apps icons to make this prettier (i.e. white background). |
|||
►
Sign in to add a comment |
|||
Comment 1 by scottmg@chromium.org
, Jun 17 2016