Issue metadata
Sign in to add a comment
|
Blue selection border shows around notifications in notification center |
||||||||||||||||||||||||||||||
Issue descriptionGoogle Chrome 53.0.2768.0 (Official Build) dev (64-bit) Revision 0 Platform 8459.0.0 (Official Build) dev-channel samus What steps will reproduce the problem? (1) Take screenshot or download any image (2) Open notification center What do you see instead? Blue selection border shows around notification Attached screenshot.
,
Jun 17 2016
That is the focus border of a focused view. And we set up the focus painter intentionally for MessageView [1] and buttons [2] Justine, could you confirm this is intentional? [1] https://cs.chromium.org/chromium/src/ui/message_center/views/message_view.cc?rcl=0&l=62 [2] https://cs.chromium.org/chromium/src/ui/message_center/views/message_center_button_bar.cc?rcl=1466147820&l=81
,
Jun 17 2016
The focus border should not be shown until the user starts using the keyboard to navigate the various pieces of the notification.
,
Jun 17 2016
Issue 620653 has been merged into this issue.
,
Jun 17 2016
karandeepb@, think it is related to your recent focus work. Could you take a look? Thanks.
,
Jun 20 2016
So I investigated a bit, the view is getting focus because of the RequestFocus call here - https://cs.chromium.org/chromium/src/ui/message_center/views/message_center_bubble.cc?sq=package:chromium&dr=CSs&l=106. This was added recently in https://codereview.chromium.org/2054473003. Assigning to dtseng@ for further action.
,
Jun 20 2016
,
Jul 4 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2 2016
For accessibility, it makes sense to have a focused view when you get to the notification center via alt+shift+n. This matches the behavior for the launcher and status tray.
,
Aug 2 2016
,
Aug 10 2016
Yeah but we should not show this blue notification for non-accessibity use cases. It goes very much against the design. Also the blue highlight is rendered pretty badly. This should be fixed in M53. We can't ship with this
,
Aug 10 2016
,
Aug 10 2016
dtseng@ can you disable this for 53? I agree that it makes sense to have those controls focusable and keyboard-navigable, but we need to go through UI review if we're going to add it.
,
Aug 10 2016
Issue 635936 has been merged into this issue.
,
Aug 10 2016
dtseng@ Do you have an ETA on when the CL will land? This is currently a stable blocker.
,
Aug 12 2016
I reverted my change, but this is *not* just an accessibility issue. By not providing focus, how does anyone using the keyboard know alt+shift+n did anything? This is clearly wrong. I'd recommend fixing the highlight to look nice and re-introduce the focus behavior.
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86817289921e010c0e4a8595ea9be48730a45a04 commit 86817289921e010c0e4a8595ea9be48730a45a04 Author: dtseng <dtseng@chromium.org> Date: Fri Aug 12 18:59:47 2016 Partial revert of change to make Notification Center focusable after alt+shift+n Reason for partial revert: See the bug for more comments. Original cl: https://codereview.chromium.org/2054473003 BUG= 620801 TBR=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2242733003 Cr-Commit-Position: refs/heads/master@{#411723} [modify] https://crrev.com/86817289921e010c0e4a8595ea9be48730a45a04/ui/message_center/views/message_center_view.cc
,
Aug 12 2016
,
Aug 13 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b61b2b13a044d2aeef5d3a9a80204f7bf6e9ad9 commit 6b61b2b13a044d2aeef5d3a9a80204f7bf6e9ad9 Author: David Tseng <dtseng@chromium.org> Date: Tue Aug 16 21:02:54 2016 Merge to m53: Partial revert of change to make Notification Center focusable after alt+shift+n Reason for partial revert: See the bug for more comments. Original cl: https://codereview.chromium.org/2054473003 BUG= 620801 TBR=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2242733003 Cr-Commit-Position: refs/heads/master@{#411723} (cherry picked from commit 86817289921e010c0e4a8595ea9be48730a45a04) Review URL: https://codereview.chromium.org/2255543003 . Cr-Commit-Position: refs/branch-heads/2785@{#631} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/6b61b2b13a044d2aeef5d3a9a80204f7bf6e9ad9/ui/message_center/views/message_center_view.cc
,
Aug 23 2016
Verified on M53 beta 8530.66.0, 53.0.2785.76
,
Aug 25 2016
I'm still able to repro in 54.0.2830.0. afakhry@ can you take a look?
,
Aug 25 2016
On 54.0.2838.0, tabbing into the notification still shows the blue border [attached screenshot]. Is that not expected?
,
Aug 25 2016
Think the bug is about fixing the default focus. That is, when the message center is open, there should be no focus thus no blue frames. When user hits <tab>/<shift-tab> to start keyboard navigation, the blue frame should show up.
,
Aug 25 2016
Yes, without tabbing there's no border. I believe this is fixed already.
,
Aug 25 2016
Just a comment. I think the *root* bug is the blue selection focus indicator needs to look better. The default focus behavior I think is correct but we reverted because the blue selection focus indicator is not up to UX standards. Can someone help with this?
,
Aug 25 2016
By help you mean design a better looking focus indicator?
,
Aug 25 2016
It's still an issue if you have no notifications. The bell gets the highlight immediately on opening the notification center. There's 2 stages to fixing this: 1: Just opening the notification center should not show a blue highlight by default. 2: Longer term, we need PM/UX owners to define what the RIGHT keyboard behavior should be for notifications and we should make that happen.
,
Aug 25 2016
Any thoughts on why this one is RBS?
,
Aug 26 2016
Issue 640935 has been merged into this issue.
,
Aug 26 2016
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/910a888e51a6544f8092e748166173bf13af32b1 commit 910a888e51a6544f8092e748166173bf13af32b1 Author: afakhry <afakhry@chromium.org> Date: Fri Aug 26 19:34:48 2016 No initial focusing of buttons in the message center bubble Unless the user manually tabs in the message center bubble, we shouldn't request the focus by default to prevent the ugly blue border from showing automatically [See screenshot: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/view?usp=sharing] BUG= 620801 Review-Url: https://codereview.chromium.org/2281983002 Cr-Commit-Position: refs/heads/master@{#414779} [modify] https://crrev.com/910a888e51a6544f8092e748166173bf13af32b1/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc [modify] https://crrev.com/910a888e51a6544f8092e748166173bf13af32b1/ui/message_center/views/message_center_bubble.cc
,
Aug 26 2016
,
Aug 26 2016
Should merge to M53?
,
Aug 29 2016
Yes.
,
Aug 29 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 29 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dfb93213cc5fb0c1f92e4ad5d652b85670ca541 commit 5dfb93213cc5fb0c1f92e4ad5d652b85670ca541 Author: Ahmed Fakhry <afakhry@google.com> Date: Mon Aug 29 17:27:01 2016 [Merge to M53] No initial focusing of buttons in the message center bubble Unless the user manually tabs in the message center bubble, we shouldn't request the focus by default to prevent the ugly blue border from showing automatically [See screenshot: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/view?usp=sharing] TBR=stevenjb@chromium.org BUG= 620801 Review-Url: https://codereview.chromium.org/2281983002 Cr-Commit-Position: refs/heads/master@{#414779} (cherry picked from commit 910a888e51a6544f8092e748166173bf13af32b1) Review URL: https://codereview.chromium.org/2293563002 . Cr-Commit-Position: refs/branch-heads/2785@{#778} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/5dfb93213cc5fb0c1f92e4ad5d652b85670ca541/ui/message_center/views/message_center_bubble.cc
,
Aug 29 2016
,
Sep 6 2016
+ lpalmaro The core of this bug still isn't addressed the blue highlight border that appears as a result of keyboard focus). We simply just hide it by making notification center non-focused by default.
,
Sep 6 2016
,
Sep 6 2016
Removing release block since that aspect of this is addressed, but yes. We need to figure out the CORRECT way to handle keyboard focus in notifications. kuscher@ is there someone on your team who can own it?
,
Sep 7 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 7 2017
Assigning to yoshiki@ for Chrome OS notifications team triage.
,
Nov 10 2017
I can't see this issue anymore. Please reopen if you still see this issue.
,
Nov 11 2017
M64 TOT |
|||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||
Comment 1 by abodenha@chromium.org
, Jun 16 2016Labels: -Pri-2 Pri-1
Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)