New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620799 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Enforce GN formatting on *.typemap files

Project Member Reported by kylec...@chromium.org, Jun 16 2016

Issue description

Mojo StructTrait files require a special *.typemap file that is valid GN syntax. It seems like presubmit checks and git cl format should treat these files the same as *.gn or *.gni files. Talking with rockot@ he seems to agree.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/58edce2b909d295f97ccfbaf13705185541eca13

commit 58edce2b909d295f97ccfbaf13705185541eca13
Author: kylechar <kylechar@chromium.org>
Date: Fri Jun 17 13:07:51 2016

Enforce GN formatting for *.typemap files.

Ensure consistent formatting for Mojo typemap files that define the
build rules to generate StructTraits.

BUG= 620799 
TEST=Tested locally, both presubmit and git cl format work as expected.

Review-Url: https://codereview.chromium.org/2074793002

[modify] https://crrev.com/58edce2b909d295f97ccfbaf13705185541eca13/git_cl.py
[modify] https://crrev.com/58edce2b909d295f97ccfbaf13705185541eca13/presubmit_canned_checks.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/7f90b17397813806ef67f546b3fc8fbffd5d5938

commit 7f90b17397813806ef67f546b3fc8fbffd5d5938
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jun 17 13:15:53 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/58edce2b909d295f97ccfbaf13705185541eca13 Enforce GN formatting for *.typemap files. (kylechar@chromium.org)

R=kylechar@chromium.org
BUG= 620799 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2075113002

[modify] https://crrev.com/7f90b17397813806ef67f546b3fc8fbffd5d5938/infra/config/recipes.cfg

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 17 2016

Sign in to add a comment