Issue metadata
Sign in to add a comment
|
Japanese Candidate window disappears when hitting "Tab" key |
||||||||||||||||||||||
Issue descriptionChrome Version : 53.0.2768.0 Platform : 8462.0.0 - Candy What steps will reproduce the problem? (1) add "Google Japanese input(for US keyboard) from chrome://settings (2) set IME to Japanese (3) enter "kabusiki" on any input field (Gmail/Compose) except the omnibox (4) hit "Tab" key while opening Ja candidate window What is the expected result? Should be able to see the more lists on the candidate window while hitting the Tab key What happens instead? The candidate window is gone when hitting "Tab" key Please provide any additional information below. Attach a screenshot if possible. Not reproducible in CrOS 8350.31.0/ Chrome 52.0.2743.41 Not reproducible in Omnibox, Findinpage -53.0.2768.0/8462.0.0
,
Jun 16 2016
,
Jun 17 2016
When hitting "Tab" key, it exits the Ja-IME, and toggle the tab key on main window. Ex: Enter "kabusiki" on Gmail/Compose. After hitting "Tab" key while opening candidate window, "Send" button is focused.
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c87c4c1db691498c68b73794769ab5e4d0fc3417 commit c87c4c1db691498c68b73794769ab5e4d0fc3417 Author: shuchen <shuchen@chromium.org> Date: Fri Jun 17 13:43:19 2016 The PROCESSKEY event triggered by IME should not carry the real DomKey/DomCode to avoid wrongly processing by chrome. BUG= 620794 Review-Url: https://codereview.chromium.org/2072213003 Cr-Commit-Position: refs/heads/master@{#400421} [modify] https://crrev.com/c87c4c1db691498c68b73794769ab5e4d0fc3417/ui/base/ime/input_method_chromeos.cc [modify] https://crrev.com/c87c4c1db691498c68b73794769ab5e4d0fc3417/ui/base/ime/input_method_chromeos_unittest.cc
,
Jun 18 2016
,
Jun 18 2016
,
Jun 22 2016
I am experiencing this issue on Mac OS X (10.11.5) with canary 53.0.2774.3. Google Japanese Input version is 2.17.2400.1. Should I open a new ticket?
,
Jun 22 2016
Yes, the issue on Mac is a different issue than this one.
,
Jun 22 2016
Thanks! Created issue 622158 .
,
Jul 1 2016
The fix for this breaks dead key information for the fabricated key events. You basically disabled the test chongz@ wrote and undid his change without consulting him.
,
Jul 3 2016
Sorry, I will revert the fix CL.
,
Jul 3 2016
,
Jul 3 2016
dtapuska@, this issue seems to share the same root cause of issue 622158 . Can you please confirm? Thanks.
,
Jul 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aad5b1b1de80ef24ea5b8bea75dabf3b8e39dc1f commit aad5b1b1de80ef24ea5b8bea75dabf3b8e39dc1f Author: shuchen <shuchen@chromium.org> Date: Mon Jul 04 01:15:22 2016 Revert of The PROCESSKEY event triggered by IME should not carry the real DomKey/DomCode to avoid wrongly pro… (patchset #3 id:40001 of https://codereview.chromium.org/2072213003/ ) Reason for revert: Refer to comment #10 of crbug.com/620794 : The fix for this breaks dead key information for the fabricated key events. Original issue's description: > The PROCESSKEY event triggered by IME should not carry the real DomKey/DomCode to avoid wrongly processing by chrome. > > BUG= 620794 > > Committed: https://crrev.com/c87c4c1db691498c68b73794769ab5e4d0fc3417 > Cr-Commit-Position: refs/heads/master@{#400421} TBR=suzhe@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 620794 Review-Url: https://codereview.chromium.org/2120133002 Cr-Commit-Position: refs/heads/master@{#403625} [modify] https://crrev.com/aad5b1b1de80ef24ea5b8bea75dabf3b8e39dc1f/ui/base/ime/input_method_chromeos.cc [modify] https://crrev.com/aad5b1b1de80ef24ea5b8bea75dabf3b8e39dc1f/ui/base/ime/input_method_chromeos_unittest.cc
,
Jul 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/febbb09d4df69afde4e6294a842a02e90a9cabdf commit febbb09d4df69afde4e6294a842a02e90a9cabdf Author: dtapuska <dtapuska@chromium.org> Date: Tue Jul 05 03:58:01 2016 Don't perform the default action when keyCode is 229. The keyCode of 229 signifies that this event is being dispatched during an IME composition. Previously keyIdentifier ended up being ProcessKey but with the converstion to key events this started to be processed. Put a conditional around the event to ensure that keyCode == 229 events are discarded. This will eventually be replaced with the isComposing flag that should be added to KeyboardEvent. BUG= 620794 , 622158 Review-Url: https://codereview.chromium.org/2121843002 Cr-Commit-Position: refs/heads/master@{#403737} [modify] https://crrev.com/febbb09d4df69afde4e6294a842a02e90a9cabdf/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
,
Jul 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be5ae235b1fd6fcbe8bae4500e100ae9eacca8db commit be5ae235b1fd6fcbe8bae4500e100ae9eacca8db Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Jul 06 13:36:28 2016 Don't perform the default action when keyCode is 229. The keyCode of 229 signifies that this event is being dispatched during an IME composition. Previously keyIdentifier ended up being ProcessKey but with the converstion to key events this started to be processed. Put a conditional around the event to ensure that keyCode == 229 events are discarded. This will eventually be replaced with the isComposing flag that should be added to KeyboardEvent. BUG= 620794 , 622158 Review-Url: https://codereview.chromium.org/2121843002 Cr-Commit-Position: refs/heads/master@{#403737} (cherry picked from commit febbb09d4df69afde4e6294a842a02e90a9cabdf) Review URL: https://codereview.chromium.org/2127843002 . Cr-Commit-Position: refs/branch-heads/2785@{#26} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/be5ae235b1fd6fcbe8bae4500e100ae9eacca8db/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
,
Jul 6 2016
,
Sep 27 2016
,
Jan 21 2017
,
Feb 22 2017
9202.35.0 / 57.0.2987.72 beta |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by songsuk@chromium.org
, Jun 16 2016Labels: ReleaseBlock-Stable