Some upcoming v8 changes for Math.exp break some webaudio tests because the expected results are slightly different. The v8 changes should actually improve the accuracy of Math.exp, so we need to disable some tests for the v8 changes to land. We'll fix up the failures afterwards. See https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7508 for the failures. See https://codereview.chromium.org/2077533002/ for the v8 changes.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/994938c2a8601705e3b44a95fc932b38ba683426 commit 994938c2a8601705e3b44a95fc932b38ba683426 Author: bmeurer <bmeurer@chromium.org> Date: Fri Jun 17 03:45:45 2016 Mark webaudio tests as needing manual rebaseline V8 is changing Math.exp to be more accurate and this breaks some WebAudio tests. Mark them as needs manual rebaseline so the V8 change can land. We'll rebaseline these after the change lands. The tests actually pass, but the printed results are slightly different. R=rtoy@chromium.org BUG= chromium:620786 NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2071123003 Cr-Commit-Position: refs/heads/master@{#400347} [modify] https://crrev.com/994938c2a8601705e3b44a95fc932b38ba683426/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ef18cc67556becfc5ee70c478d51d3e046ef4a4 commit 6ef18cc67556becfc5ee70c478d51d3e046ef4a4 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Jun 17 05:11:43 2016 NeedsRebaseline for crbug.com/620786 BUG= 620786 Review URL: https://codereview.chromium.org/2075063002 . Cr-Commit-Position: refs/heads/master@{#400362} [modify] https://crrev.com/6ef18cc67556becfc5ee70c478d51d3e046ef4a4/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37 commit d5f2ac5e3326f281cbe7ba57464a4b17a9938e37 Author: bmeurer <bmeurer@chromium.org> Date: Fri Jun 17 05:19:35 2016 [builtins] Introduce proper Float64Exp operator. Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.exp() as TurboFan builtin and use that operator to also inline Math.exp() into optimized TurboFan functions. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel BUG= v8:3266 , v8:3468 , v8:3493 , v8:5086 , v8:5108 , chromium:620786 R=mvstanton@chromium.org Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260 Review-Url: https://codereview.chromium.org/2077533002 Cr-Original-Commit-Position: refs/heads/master@{#37037} Cr-Commit-Position: refs/heads/master@{#37047} [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/arm/codegen-arm.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/arm/codegen-arm.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/arm64/codegen-arm64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/arm64/codegen-arm64.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/assembler.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/assembler.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/base/ieee754.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/base/ieee754.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/bootstrapper.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/builtins.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/builtins.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/codegen.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/codegen.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/arm/code-generator-arm.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/arm64/code-generator-arm64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/code-assembler.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/ia32/code-generator-ia32.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/instruction-codes.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/instruction-scheduler.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/instruction-selector.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/js-builtin-reducer.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/js-builtin-reducer.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/machine-operator-reducer.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/machine-operator.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/machine-operator.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/mips/code-generator-mips.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/mips64/code-generator-mips64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/opcodes.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/raw-machine-assembler.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/representation-change.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/simplified-lowering.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/simplified-operator.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/simplified-operator.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/typer.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/verifier.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/compiler/x64/code-generator-x64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/contexts.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/arm/lithium-arm.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/arm/lithium-arm.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/arm/lithium-codegen-arm.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/arm64/lithium-arm64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/arm64/lithium-arm64.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/arm64/lithium-codegen-arm64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/hydrogen-instructions.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/hydrogen.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/ia32/lithium-codegen-ia32.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/ia32/lithium-ia32.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/ia32/lithium-ia32.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/mips/lithium-codegen-mips.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/mips/lithium-mips.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/mips/lithium-mips.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/mips64/lithium-codegen-mips64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/mips64/lithium-mips64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/mips64/lithium-mips64.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/x64/lithium-codegen-x64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/x64/lithium-x64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/crankshaft/x64/lithium-x64.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/external-reference-table.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/ia32/codegen-ia32.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/ia32/codegen-ia32.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/js/math.js [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/mips/codegen-mips.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/mips/codegen-mips.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/mips64/codegen-mips64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/mips64/codegen-mips64.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/runtime/runtime-maths.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/runtime/runtime.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/third_party/fdlibm/fdlibm.js [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/v8.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/x64/codegen-x64.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/src/x64/codegen-x64.h [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/test/cctest/compiler/test-run-machops.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/test/unittests/base/ieee754-unittest.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/test/unittests/compiler/js-builtin-reducer-unittest.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/test/unittests/compiler/machine-operator-reducer-unittest.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/test/unittests/compiler/node-test-utils.cc [modify] https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37/test/unittests/compiler/node-test-utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4648e31d0db0435998610699992cf3085506973d commit 4648e31d0db0435998610699992cf3085506973d Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Fri Jun 17 06:34:40 2016 Auto-rebaseline for r400362 https://chromium.googlesource.com/chromium/src/+/6ef18cc67 BUG= 620786 TBR=wangxianzhu@chromium.org Review URL: https://codereview.chromium.org/2072193002 . Cr-Commit-Position: refs/heads/master@{#400381} [modify] https://crrev.com/4648e31d0db0435998610699992cf3085506973d/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bc070846747b5e3d587df7b39f6c32a35d71dac commit 2bc070846747b5e3d587df7b39f6c32a35d71dac Author: rtoy <rtoy@chromium.org> Date: Fri Jun 17 18:48:40 2016 Manual rebaseline webaudio tests after V8 Math.exp update. BUG= 620786 Review-Url: https://codereview.chromium.org/2079003002 Cr-Commit-Position: refs/heads/master@{#400470} [modify] https://crrev.com/2bc070846747b5e3d587df7b39f6c32a35d71dac/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/2bc070846747b5e3d587df7b39f6c32a35d71dac/third_party/WebKit/LayoutTests/webaudio/audioparam-setTargetAtTime-continuous-expected.txt [modify] https://crrev.com/2bc070846747b5e3d587df7b39f6c32a35d71dac/third_party/WebKit/LayoutTests/webaudio/audioparam-setTargetAtTime-limit-expected.txt [modify] https://crrev.com/2bc070846747b5e3d587df7b39f6c32a35d71dac/third_party/WebKit/LayoutTests/webaudio/audioparam-setTargetAtTime-sampling-expected.txt [modify] https://crrev.com/2bc070846747b5e3d587df7b39f6c32a35d71dac/third_party/WebKit/LayoutTests/webaudio/stereopannernode-no-glitch-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/a54e289e68c649cb3f1fc33d27b850d825d575cb commit a54e289e68c649cb3f1fc33d27b850d825d575cb Author: bjaideep <bjaideep@ca.ibm.com> Date: Sat Jun 18 09:35:44 2016 PPC/s390: [builtins] Introduce proper Float64Exp operator. Port d5f2ac5e3326f281cbe7ba57464a4b17a9938e37 Original commit message: Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.exp() as TurboFan builtin and use that operator to also inline Math.exp() into optimized TurboFan functions. R=bmeurer@chromium.org, mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= v8:3266 , v8:3468 , v8:3493 , v8:5086 , v8:5108 , chromium:620786 LOG=N Review-Url: https://codereview.chromium.org/2075263002 Cr-Commit-Position: refs/heads/master@{#37073} [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/compiler/ppc/code-generator-ppc.cc [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/compiler/s390/code-generator-s390.cc [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/crankshaft/ppc/lithium-codegen-ppc.cc [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/crankshaft/ppc/lithium-ppc.cc [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/crankshaft/ppc/lithium-ppc.h [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/crankshaft/s390/lithium-codegen-s390.cc [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/crankshaft/s390/lithium-s390.cc [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/crankshaft/s390/lithium-s390.h [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/ppc/codegen-ppc.cc [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/ppc/codegen-ppc.h [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/s390/codegen-s390.cc [modify] https://crrev.com/a54e289e68c649cb3f1fc33d27b850d825d575cb/src/s390/codegen-s390.h
Comment 1 by bmeu...@chromium.org
, Jun 16 2016