New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620758 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in epoll_add

Project Member Reported by ClusterFuzz, Jun 16 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6649947634270208

Fuzzer: ipc_fuzzer_gen
Job Type: linux_asan_chrome_ipc
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 8
Crash Address: 0x61500002faf0
Crash State:
  epoll_add
  event_add
  base::MessagePumpLibevent::WatchFileDescriptor
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_ipc&range=398351:398496

Minimized Testcase (240.23 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94wCfMbaQ3tYBg_e9eBk7x2YHRC1MpbPZg_dwX7C0veLfbyyqAecABu20i0rMcTg9AaMzm8XVNarA7p0lAPoY8e_wQzzBHnkLWyXK5pFlY1QW3zPEQOT_J7h12jSQiRwhCAB4mnc6Yt9cTt7aU1cYNgmX0DrzHk1Y1liFb5ls5LlNzJCdI

Filer: inferno

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: och...@chromium.org
Owner: roc...@chromium.org
Status: Assigned (was: Available)
Looks like https://bugs.chromium.org/p/chromium/issues/detail?id=610337 still reproducing.

Comment 2 by est...@chromium.org, Jun 16 2016

Components: Internals
Labels: M-53
Project Member

Comment 3 by ClusterFuzz, Jun 17 2016

ClusterFuzz has detected this issue as fixed in range 398496:398573.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6649947634270208

Fuzzer: ipc_fuzzer_gen
Job Type: linux_asan_chrome_ipc
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 8
Crash Address: 0x61500002faf0
Crash State:
  epoll_add
  event_add
  base::MessagePumpLibevent::WatchFileDescriptor
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_ipc&range=398351:398496
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_ipc&range=398496:398573

Minimized Testcase (240.23 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94wCfMbaQ3tYBg_e9eBk7x2YHRC1MpbPZg_dwX7C0veLfbyyqAecABu20i0rMcTg9AaMzm8XVNarA7p0lAPoY8e_wQzzBHnkLWyXK5pFlY1QW3zPEQOT_J7h12jSQiRwhCAB4mnc6Yt9cTt7aU1cYNgmX0DrzHk1Y1liFb5ls5LlNzJCdI

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 4 by aarya@google.com, Jun 17 2016

Labels: ClusterFuzz-Wrong
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 17 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 17 2016

Labels: Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0a6234831ce289c4b16327d2418e5ff3c623d54

commit f0a6234831ce289c4b16327d2418e5ff3c623d54
Author: rockot <rockot@chromium.org>
Date: Fri Jun 17 22:14:55 2016

[mojo-edk] Prevent watching an invalid FD on early broker pipe closure

If a parent process closes the broker OS pipe to a child before
that child can request a NodeChannel FD from it, the child will
silently ignore this failure and try to bring up a NodeChannel over
an invalid FD.

This means adding FileDescriptorWatchers and ultimately calling
epoll_add on the invalid descriptor, hence the linked bug.

This CL fixes that by terminating child-parent connection early
when the Broker fails to acquire a valid NodeChannel FD.

BUG= 620758 
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2072233005
Cr-Commit-Position: refs/heads/master@{#400523}

[modify] https://crrev.com/f0a6234831ce289c4b16327d2418e5ff3c623d54/mojo/edk/system/node_controller.cc

Comment 8 by roc...@chromium.org, Jun 17 2016

Status: Fixed (was: Assigned)
Project Member

Comment 9 by ClusterFuzz, Jun 18 2016

Labels: Merge-NA
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 18 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta -ClusterFuzz -merge-na Clusterfuzz Merge-na
Fix already in M53, removing ReleaseBlock-Beta.
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 24 2016

Labels: -Restrict-View-SecurityNotify
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 2 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic
Labels: -ClusterFuzz-Wrong
We have made a bunch of changes on ClusterFuzz side, so resetting ClusterFuzz-Wrong label.

Sign in to add a comment