New issue
Advanced search Search tips

Issue 620755 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Use data saver information to decide whether to preload

Project Member Reported by mlamouri@chromium.org, Jun 16 2016

Issue description

With WMPI, we make a decision based on the cellular connection type which is hand wavy at best. If we use the data saver information set by the embedder, the decision can be smarter and match other behaviours. In addition, autoplay decisions are made depending on this.

Furthermore, we should fix the fact that we are actually loading files that are marked as 'autoplay' :)
 
Labels: -Pri-2 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f23c95e8717937364735d634323c6cf9d707a7f

commit 8f23c95e8717937364735d634323c6cf9d707a7f
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Jun 22 15:12:38 2016

Use data saver information to decide whether to preload.

This is done in addition of the connection type checking. We would
like to only use the data saver information going forward.

It's also fixing a bug where a <video autoplay> would always preload.

BUG= 620755 

Review-Url: https://codereview.chromium.org/2071793003
Cr-Commit-Position: refs/heads/master@{#401281}

[add] https://crrev.com/8f23c95e8717937364735d634323c6cf9d707a7f/third_party/WebKit/LayoutTests/media/video-preload-datasaver.html
[modify] https://crrev.com/8f23c95e8717937364735d634323c6cf9d707a7f/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Status: Fixed (was: Started)

Sign in to add a comment