LayerTreeHostCommonTest.TransformAboveRootLayer fails on Nexus 5X |
||||
Issue descriptionThe Android N5X Swarm Builder[1] is a new builder that we are greening up in order to eventually make a CQ bot for 64-bot Android M. cc_unittests currently fails on this bot in LayerTreeHostCommonTest.TransformAboveRootLayer [2]: C 45.462s Main [ RUN ] LayerTreeHostCommonTest.TransformAboveRootLayer C 45.462s Main ../../cc/trees/layer_tree_host_common_unittest.cc:1214: Failure C 45.462s Main Value of: child->draw_properties().target_space_transform C 45.462s Main Actual: [ +1.5000 +0.0000 +0.0000 +50.0000 C 45.462s Main +0.0000 +1.5000 +0.0000 +50.0000 C 45.462s Main +0.0000 +0.0000 +1.0000 +0.0000 C 45.462s Main +0.0000 +0.0000 +0.0000 +1.0000 ] C 45.462s Main C 45.462s Main Expected: device_scaled_translate C 45.462s Main Which is: [ +1.5000 +0.0000 +0.0000 +50.0000 C 45.462s Main +0.0000 +1.5000 +0.0000 +50.0000 C 45.462s Main +0.0000 +0.0000 +1.0000 +0.0000 C 45.462s Main +0.0000 +0.0000 +0.0000 +1.0000 ] C 45.462s Main C 45.462s Main [ FAILED ] LayerTreeHostCommonTest.TransformAboveRootLayer (3 ms) [1] https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder [2] https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FAndroid_N5X_Swarm_Builder%2F1016%2F%2B%2Frecipes%2Fsteps%2Fcc_unittests_on_Android%2F0%2Fstdout
,
Jun 16 2016
weiliangc@, do you have an idea of what to do here? I imagine an EXPECT_EQ needs to be changed to an EXPECT_FLOAT_EQ or EXPECT_DOUBLE_EQ, but I'm not sure where.
,
Jun 16 2016
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c351772b8fccf166e4318d4fc57c771cbe4a99d0 commit c351772b8fccf166e4318d4fc57c771cbe4a99d0 Author: weiliangc <weiliangc@chromium.org> Date: Tue Jun 28 22:52:02 2016 cc: Use transform specific EXPECT for unittests Instead of use EXPECT_EQ, use EXPECT_TRANSFORMATION_MATRIX_EQ to deal with float in gfx::Transform. R=danakj BUG= 620747 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2103963002 Cr-Commit-Position: refs/heads/master@{#402584} [modify] https://crrev.com/c351772b8fccf166e4318d4fc57c771cbe4a99d0/cc/trees/layer_tree_host_common_unittest.cc
,
Jun 29 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by stip@chromium.org
, Jun 16 2016