New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620666 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Background colour of theme is seen while opening devtools window.

Reported by dmascare...@etouch.net, Jun 16 2016

Issue description

Chrome Version:53.0.2769.0 (Official Build)Revision 8cdb012b5e4b8e6b9820da0e8d25fcf0dfd02631-refs/heads/master@{#400041} 32/64-bit
OS:Windows(7,8,10),Linux(Ubuntu 14.04 LTS), Mac(10.10.5, 10.11.4)

Test url: 1.https://chrome.google.com/webstore/detail/galaxy-view/dcbeddldohkakodfncjnkkjfojggbahp?utm_source=chrome-ntp-icon
          2.https://chrome.google.com/webstore/detail/coral-reef/ceopnaonhcpfbjpmianoabhebgnifjoi?utm_source=chrome-ntp-icon

What steps will reproduce the problem?
1. Launch chrome and Apply any theme using above test urls.
2. Navigate to http://www.orimi.com/pdf-test.pdf and right click ,select ‘Inspect’ option from context menu.
3. Observe.

Actual: Background colour of theme is seen while opening devtools window.
Expected: Theme background colour should not be seen while opening the devtools window.

This is regression issue, broken in ‘M 51’ and will soon update other info :

 
Actual_dev.mov
6.0 MB Download
Labels: hasbisect
Owner: ccameron@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/8526ab53583e2cc6390fb4693132b151d2481ea1..1ba5ac190a8a46a6ac5b8f1b06bcb66ec6eb967e?pretty=fuller&n=100

Suspecting: r382955 ?

Good build:51.0.2688.0
Bad build:51.0.2689.0

Kindly help to re-assign, if your changes are not cause for this issue.

Project Member

Comment 2 by sheriffbot@chromium.org, Jul 4 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-54 M-55
Above issue is still reproducible on Latest Canary Version:55.0.2878.0 (Official Build) 6bf82374fb3a17659851bc4e830c063577ba80fd-refs/heads/master@{#422326} 
Status: Fixed (was: Assigned)
I think that this was fixed by https://codereview.chromium.org/2824613002

We no longer send the theme background color to layers (rather, we let them start as transparent).

I tested on Canary, and I don't see the background color, though it does take a while for the window to appear.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74f5685cc24d74459f34df339a3058ee25c821d3

commit 74f5685cc24d74459f34df339a3058ee25c821d3
Author: Marc-Antoine Courteau <macourteau@chromium.org>
Date: Thu Aug 10 21:07:18 2017

[Payment Request] Shows a more useful editor title for the Contact Info dialog.

When data is missing, and the editor is opened because of that, the dialog's
title will prompt for the missing data.

Bug:  620666 
Change-Id: Iafc0e741c25297a24cb4d24be29d58d366a7c940
Reviewed-on: https://chromium-review.googlesource.com/609207
Reviewed-by: mahmadi (Moe) <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493543}
[modify] https://crrev.com/74f5685cc24d74459f34df339a3058ee25c821d3/components/payments/core/payments_profile_comparator.cc
[modify] https://crrev.com/74f5685cc24d74459f34df339a3058ee25c821d3/components/payments/core/payments_profile_comparator.h
[modify] https://crrev.com/74f5685cc24d74459f34df339a3058ee25c821d3/components/payments/core/payments_profile_comparator_unittest.cc
[modify] https://crrev.com/74f5685cc24d74459f34df339a3058ee25c821d3/ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm
[modify] https://crrev.com/74f5685cc24d74459f34df339a3058ee25c821d3/ios/chrome/browser/ui/payments/contact_info_edit_mediator_unittest.mm

Sign in to add a comment