New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620663 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Undefined-shift in is_one_of

Project Member Reported by ClusterFuzz, Jun 16 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4591483693039616

Fuzzer: libfuzzer_harfbuzz_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  is_one_of
  final_reordering_syllable
  final_reordering
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=395543:395578

Minimized Testcase (15.77 Kb): https://cluster-fuzz.appspot.com/download/AMIfv967w1Lx2IRk73Phq3pHHk-y_zgmKSo8JcPDYqpTxYs0xvx569A-ycX2CJFPIb2uZitThYyILUSqlC7apS5NKmkwz2rQLr4uLvLcx6icUQ-tOhBXmZprcGBUUEdsL3l00Ie-tCnqRz2JJS8_NHSde1xwW9G_-A

Filer: mmoroz

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 by mmoroz@chromium.org, Jun 16 2016

Cc: mmoroz@chromium.org kcc@chromium.org aizatsky@chromium.org
Owner: behdad@chromium.org

Comment 2 by behdad@chromium.org, Jul 20 2016

Humm.  It's really hard to make the code do this.  And I cannot reproduce using the minimized-testcase and hb-fuzzer on the commandline, when I put an assert on the line it claims the bad shift happens.

kcc@, can you reproduce?

Comment 3 by mmoroz@chromium.org, Jul 20 2016

Hm, there is some flakiness with reproduction. I cannot reproduce it with a single run, but passing '-runs=65535' makes sense:


$ UBSAN_OPTIONS=print_stacktrace=1:symbolize=1:print_summary=1:halt_on_error=1 ./harfbuzz_fuzzer ./fuzz-1-harfbuzz_fuzzer 
WARNING: Failed to find function "__sanitizer_print_stack_trace".
INFO: Seed: 1720945826
<...>/harfbuzz_fuzzer: Running 1 inputs 1 time(s) each.
Running: ./fuzz-1-harfbuzz_fuzzer
Executed ./fuzz-1-harfbuzz_fuzzer in 3 ms




$ UBSAN_OPTIONS=print_stacktrace=1:symbolize=1:print_summary=1:halt_on_error=1 <...>/harfbuzz_fuzzer ./fuzz-1-harfbuzz_fuzzer -runs=65535
WARNING: Failed to find function "__sanitizer_print_stack_trace".
INFO: Seed: 2963359902
<...>/harfbuzz_fuzzer: Running 1 inputs 65535 time(s) each.
Running: ./fuzz-1-harfbuzz_fuzzer
../../third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc:145:13: runtime error: shift exponent 94 is too large for 32-bit type 'unsigned int'
    #0 0x4b900d in is_one_of out/Release/../../third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc:145:13
    #1 0x4b900d in final_reordering_syllable out/Release/../../third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc:1360

Comment 4 by behdad@chromium.org, Jul 20 2016

Humm.  I need debugging this as I cannot reproduce with hb-fuzzer in harfbuzz itself no matter how many times I run.

Comment 5 by mmoroz@chromium.org, Jul 21 2016

Labels: -ClusterFuzz Clusterfuzz
Strange.. Do you use correct build flags (https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md#Reproducing-LibFuzzer-UBSan-bugs) ?

Comment 6 by behdad@chromium.org, Jul 22 2016

I'm not building in Chrome, just built hb-fuzzer separately.

Project Member

Comment 7 by ClusterFuzz, Jul 22 2016

ClusterFuzz has detected this issue as fixed in range 406767:406862.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4591483693039616

Fuzzer: libfuzzer_harfbuzz_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  is_one_of
  final_reordering_syllable
  final_reordering
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=395640:395746
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=406767:406862

Minimized Testcase (15.77 Kb): https://cluster-fuzz.appspot.com/download/AMIfv967w1Lx2IRk73Phq3pHHk-y_zgmKSo8JcPDYqpTxYs0xvx569A-ycX2CJFPIb2uZitThYyILUSqlC7apS5NKmkwz2rQLr4uLvLcx6icUQ-tOhBXmZprcGBUUEdsL3l00Ie-tCnqRz2JJS8_NHSde1xwW9G_-A?testcase_id=4591483693039616

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jul 22 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by ClusterFuzz, Jul 22 2016

ClusterFuzz has detected this issue as fixed in range 406767:406862.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4591483693039616

Fuzzer: libfuzzer_harfbuzz_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  is_one_of
  final_reordering_syllable
  final_reordering
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=395640:395746
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=406767:406862

Minimized Testcase (15.77 Kb): https://cluster-fuzz.appspot.com/download/AMIfv967w1Lx2IRk73Phq3pHHk-y_zgmKSo8JcPDYqpTxYs0xvx569A-ycX2CJFPIb2uZitThYyILUSqlC7apS5NKmkwz2rQLr4uLvLcx6icUQ-tOhBXmZprcGBUUEdsL3l00Ie-tCnqRz2JJS8_NHSde1xwW9G_-A?testcase_id=4591483693039616

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment