New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620634 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.2%-50% regression in webrtc_perf_tests at 13142:13143

Project Member Reported by ivoc@chromium.org, Jun 16 2016

Issue description

See graphs below.
 

Comment 1 by ivoc@chromium.org, Jun 16 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=620634

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggtj8uAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_ICtqwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_LWUqgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggpiPsAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_LiOpQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_P_vpwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_MuRswoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_MvGogoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggpjKtwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_P_aowkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggqyhqgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_PeHvQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_Om0qAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_MvcvQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggpi0pgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_MvcvQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_OmFtQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_P-LugoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_LeVvgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_P-VqwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_LfMpwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_OnKuQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_MmzsgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_ICYrQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_P_BsgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_P_aowoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_PeHvQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_Om0qAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_MuorAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_LjSuAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_O6yqwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_IvjpAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_PfdrAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_KntvgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_O6yqwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_PfJtQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvP_PtAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_Pe2pAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_OmgsQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_Pe2pAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_OmgsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_NOJvwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_IvUoAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_LeBrwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_MnPqwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_PPbrwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_NjhrgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_PzIsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_Ni1vwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_PzcqAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_L_EoQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggszOuQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_K68uAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_L_SsAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_L-OqQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggszZpAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_PeiuQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggqy6swoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvP_TpQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_OfZuwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_Iu3tQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgguj7qgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvP_TpQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_LfMpwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_OnepAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_O6uugoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_POttgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvP_PtAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggpiguwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_O6XrwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_J6IvgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggqzVuwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_MuNqgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_O6XrwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_ICCvAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_IDmowoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_J6coAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_IvjpAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_Ly3oAoM


Bot(s) for this bug's original alert(s):

webrtc-android-tests-nexus5
webrtc-android-tests-nexus72
webrtc-android-tests-nexus9

Comment 2 by ivoc@chromium.org, Jun 16 2016

Hi Alex, your CL (https://codereview.webrtc.org/2058753003) seems to have a generally positive effect on many perf stats related to encode time and cpu usage on Android. One thing that looks a bit worrying is that 	dropped_frames/screenshare_slides deteriorated by 50% on Nexus 9. And also many of the PSNR/SSIM related perf stats on various android devices deteriorated by 1-5%. Could you have a look at this, please?
Owner: glaznev@chromium.org
Adding Alex, see comment #2
Components: Blink>WebRTC
Alex, ping on this.

Comment 5 by glaznev@webrtc.org, Jul 1 2016

Adjusting number of threads may reduce PSNR a little and this is expected, but should not have impact on the amount of dropped frames.
Please assign to marpan@or jackychen@ for triage.
Also it is possible to disable this optimization for Chromium builds if there is no easy fix, but keep it for standalone WebRTC Android builds.

Comment 6 by ivoc@chromium.org, Aug 15 2016

Owner: marpan@chromium.org
marpan@: Could you have a look at this, please?

Comment 7 by marpan@chromium.org, Aug 17 2016

Cc: jackychen@chromium.org
For screenshare in vp8, we only drop frames if we detect the current frame will be too big (i.e., on slide change) from a partial encoding (in which case we drop it and encode next frame at higher QP). Since number of threads does change the encoding a little, it may have changed the detection somewhat and dropped more. 

We'll need to verify by running the screenshare on nexus 9 device.
Labels: -Performance-Sheriff
Is this still a valid issue?
Status: WontFix (was: Assigned)
Re-open if this is still an issue.

Sign in to add a comment