New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620543 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ReportStage timing summary returns incorrect CommitQueueSyncStage duration

Project Member Reported by akes...@chromium.org, Jun 16 2016

Issue description

Example build: https://uberchromegw.corp.google.com/i/chromeos/builders/daisy-paladin/builds/23028/steps/Report/logs/stdio

"This build versus last week of daisy-paladin
Averages for 74 Builds: 887956 - 900884
 1:36:25 success  95% timeouts   1% median 1:16:18 mean 1:15:40 min 0:39:59 max 1:56:57

CleanUp:
  start:    0:13:45 median 0:02:03 mean 0:04:28 min 0:00:00 max 0:44:51
  duration: 0:00:00 median 0:00:16 mean 0:00:24 min 0:00:00 max 0:01:56
  finish:   0:13:45 median 0:02:03 mean 0:04:53 min 0:00:17 max 0:44:51
CommitQueueSync:
  start:    0:13:45 median 0:02:04 mean 0:04:53 min 0:00:18 max 0:44:51
  duration: 0:00:01 median 0:01:34 mean 0:03:58 min 0:00:00 max 0:44:14
  finish:   0:13:46 median 0:04:34 mean 0:08:52 min 0:01:53 max 0:44:51
BuildStart:
  start:    0:13:44 median 0:04:43 mean 0:08:56 min 0:02:03 max 0:44:50
  duration: 0:00:01 median 0:00:00 mean 0:00:00 min 0:00:00 max 0:00:01
  finish:   0:13:45 median 0:04:43 mean 0:08:56 min 0:02:03 max 0:44:50
BuildReexecutionFinished:
  start:    0:13:46 median 0:04:44 mean 0:08:57 min 0:02:04 max 0:44:52
  duration: 0:00:05 median 0:00:05 mean 0:00:04 min 0:00:04 max 0:00:10
  finish:   0:13:51 median 0:04:49 mean 0:09:02 min 0:02:14 max 0:44:56
ConfigDump:
  start:    0:13:51 median 0:04:49 mean 0:09:03 min 0:02:15 max 0:44:57
  duration: 0:00:00 median 0:00:00 mean 0:00:00 min 0:00:00 max 0:00:01
  finish:   0:13:51 median 0:04:49 mean 0:09:03 min 0:02:15 max 0:44:57
"
..
..
..

Claims that CommitQueueSync stage for this run took ~1 second. In actuality it took ~11 minutes.

My guess without further analysis is that there are multiple CommitQueueSyncStage entries in cidb for this build, generated by different re-executions, and that this is looking at the wrong one (i.e. one that was instantly skipped).
 
That makes sense.

I *think* the logic was to pick the last one, if there were multiple results. What do you think IS the right logic?

Pick the slowest? Pick the first? Combine them? Include all instances? Filter out failed instances and instances < 1 sec? Arrange it so that skipped stages don't appear in CIDB?

I suspect we want to pick the slowest as a quick work around, and then to stop listing skipped stages in CIDB.


Comment 2 by autumn@chromium.org, Jun 21 2016

Labels: -current-issue
Cc: akes...@chromium.org nxia@chromium.org
Cc: davidri...@chromium.org
Labels: -Pri-2 Pri-3
Status: Archived (was: Assigned)
This report no longer exists on the builders.

Sign in to add a comment