Rework how the GN //build files handle architecture-specific args for non-host/target archs |
||
Issue descriptionSome times we want to run GN and ninja on architecture A, but cross-compile for architecture B, and have some parts of the code think it should be targeting architecture C. The particular motivating example for this is the v8 JIT code, which we might want to run on x64 or x86, but have the JIT generate ARM or MIPS code that is then run under emulation. In this situation, we may need valid values for some of the architecture-specific build args, like arm_float_api or mips_arch_variant. Currently this is done by having the //build files be aware of v8_target_cpu, but we should rework this in a way that isn't v8-specific.
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/acfff97cb7e7badbf0d5c597e4d75b467e71129b commit acfff97cb7e7badbf0d5c597e4d75b467e71129b Author: machenbach <machenbach@chromium.org> Date: Thu Jun 16 08:04:08 2016 [gn] Fix targets for x86 v8_target_arch Those were wrongly translated from gyp with ia32. This should land before renaming v8_target_arch to v8_target_cpu. BUG=chromium:620527 NOTRY=true TBR=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2065323004 Cr-Commit-Position: refs/heads/master@{#37027} [modify] https://crrev.com/acfff97cb7e7badbf0d5c597e4d75b467e71129b/test/cctest/BUILD.gn [modify] https://crrev.com/acfff97cb7e7badbf0d5c597e4d75b467e71129b/test/unittests/BUILD.gn
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/909e931c942774a052b493bd0061325502373f3a commit 909e931c942774a052b493bd0061325502373f3a Author: dpranke <dpranke@chromium.org> Date: Thu Jun 16 18:43:35 2016 Rework v8_target_arch / target_cpu approach to use v8_target_cpu. This CL reworks how we get architecture-specific build args configured correctly so that they will be set when needed for either the current_cpu in the build toolchain *or* when needed to compile v8 correctly. Eventually we should rework this so that it is a generic concept and not v8 specific. R=brettw@chromium.org, thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG= 619503 , 620527 Review-Url: https://codereview.chromium.org/2070653003 Cr-Commit-Position: refs/heads/master@{#400219} [modify] https://crrev.com/909e931c942774a052b493bd0061325502373f3a/build/config/arm.gni [modify] https://crrev.com/909e931c942774a052b493bd0061325502373f3a/build/config/mips.gni [add] https://crrev.com/909e931c942774a052b493bd0061325502373f3a/build/config/v8_target_cpu.gni
,
Jun 19 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||
►
Sign in to add a comment |
||
Comment 1 by dpranke@chromium.org
, Jun 16 2016Status: Available (was: Untriaged)