New issue
Advanced search Search tips

Issue 620522 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Jun 2016
Cc:
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Fix the dedupe of verified profiles.

Project Member Reported by se...@chromium.org, Jun 16 2016 
With the code in it's current form, it is possible for a verified profile to be deleted.

By putting the verified profiles last in the list of existing profiles when deduping, the verified profiles will never be deleted.

All the non verified profiles will have the opportunity to merge together. The result will then be compared to verified profiles and dropped if there is a match.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80c06469b872723c27bf453b3f6ee8b06f747b27

commit 80c06469b872723c27bf453b3f6ee8b06f747b27
Author: sebsg <sebsg@chromium.org>
Date: Fri Jun 17 18:19:59 2016

Put the verified profiles last when deduping so they are never deleted in favor of a non verified profile.

Also added code so that verified profiles don't merge with other verified profiles.

When an unverified profiles is compared with a similar verified profile during dedupe, the verified profile is not changed and the unverified profile is discarded.

BUG= 620522 
TEST=PersonalDataManagerTest

Review-Url: https://codereview.chromium.org/2075503002
Cr-Commit-Position: refs/heads/master@{#400459}

[modify] https://crrev.com/80c06469b872723c27bf453b3f6ee8b06f747b27/components/autofill/core/browser/autofill_profile.cc
[modify] https://crrev.com/80c06469b872723c27bf453b3f6ee8b06f747b27/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/80c06469b872723c27bf453b3f6ee8b06f747b27/components/autofill/core/browser/personal_data_manager_unittest.cc

Comment 2 by se...@chromium.org, Jun 17 2016

Status: Fixed (was: Started)
►

Sign in to add a comment