New issue
Advanced search Search tips

Issue 620517 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Unlabeled button in chrome://settings

Project Member Reported by chaok@google.com, Jun 16 2016

Issue description

Mode: force_next
Version: 52.0.2743.32
Reproduction Steps: 
1. chrome://settings
2. taB 2x

Observed:
"button"

Expected:
meaningful/concise a11y-label


 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 16 2016

Labels: Hotlist-Google
Owner: dtseng@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: dbeam@chromium.org
Labels: Phase3
Looks like there is an unlabeled button in the People section of this page. There's also a button that speaks "change ellipsis" in that section which isn't helpful. I'm not quite able to tell what those two buttons are, since the highlight is not working properly right now. 

@dbeam, can you take a look at this possibly? If not, David can you tackle this? 

Comment 4 by dbeam@chromium.org, Jun 20 2016

fyi: this UI (the old chrome://settings UI) is basically deprecated and is going to be replaced as soon as we possibly can :)

Comment 5 by chaok@google.com, Jun 20 2016

Hope new UI will have a11y-labels for all controls :). 
Some settings have been labeled, however many still remain unlabeled.

Comment 7 by chaok@google.com, Oct 3 2016

Labels: -Pri-2 Pri-1

Comment 8 by dbeam@chromium.org, Oct 3 2016

Cc: dtseng@chromium.org
Owner: hcarmona@chromium.org

Comment 9 by dtseng@chromium.org, Oct 20 2016

Status: wontfix (was: Assigned)
Don't see this. The second tab stop belongs to the checkbox allow proxies for shared networks

Comment 10 by chaok@google.com, Oct 21 2016

Status: Started (was: WontFix)
All I hear is button with 2 items: 56.0.2895.0

Comment 11 Deleted

Kevin, when filing bugs like these, please include a lot more detail.

The first tab stop is a search text field
The second lands on a list with each listitem pertaining to a network connection
The third is a checkbox with a proper label "allow proxies for shared networks".

What are you expecting here? What would make a better user experience?


Labels: -Phase3 phase4
Labels: NewComponent-Accessibility-ChromeVox NewComponent-Accessibility
Status: Started (was: Assigned)
Taking a look at this issue
I looked through the buttons on the top level page and only found one unlabeled toggle button for the accessibility options. Created http://crrev.com/2801753003 to fix that, will close this issue when that lands. Please file other issues if you see unlabeled controls.
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4b092f17442ceb6ff2dbf9899f626f7b908f916

commit e4b092f17442ceb6ff2dbf9899f626f7b908f916
Author: hcarmona <hcarmona@chromium.org>
Date: Fri Apr 07 22:57:59 2017

MD-Settings: Label toggle button in Accessibility section.

BUG= 620517 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2801753003
Cr-Commit-Position: refs/heads/master@{#463031}

[modify] https://crrev.com/e4b092f17442ceb6ff2dbf9899f626f7b908f916/chrome/browser/resources/settings/a11y_page/a11y_page.html

Status: Fixed (was: Started)

Comment 19 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)

Sign in to add a comment