New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620511 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 621264
issue 621746



Sign in to add a comment

Recipe roller has spammy bugdroid messages

Project Member Reported by martiniss@chromium.org, Jun 15 2016

Issue description

If you make a recipe engine change, you'll end up with a bugdroid message like
"
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bed5ced56d75a4a63d5b4e4241e4e9aa51e2de31

commit bed5ced56d75a4a63d5b4e4241e4e9aa51e2de31
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jun 15 10:46:14 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/ed82e67abdd60ce13f7bdae56d648bd62776f0e3 annotated_run: Use builder directory for temp. (dnj@google.com)
  https://crrev.com/3ff29095a3ded4744b3dc5c7367956471a9010ba libyuv: Set android_full_debug=1 in GYP_DEFINES for Android x86. (kjellander@chromium.org)
  https://crrev.com/98122d8810af966ebd7da62629c688c1ab6c8c9a remote_run: use /b as base directory for temporary files when available (phajdan.jr@chromium.org)

R=kjellander@chromium.org,dnj@google.com,fbarchard@chromium.org,phajdan.jr@chromium.org
BUG= 593999 , libyuv:602 , chromium:620158 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2068043003

[modify] https://crrev.com/bed5ced56d75a4a63d5b4e4241e4e9aa51e2de31/infra/config/recipes.cfg
"

Which is pretty spammy for a simple change. It'd be nice if we could make this smaller, or maybe not post on every change?

I think it would be confusing if the recipe roller didn't post for every roll. For example, if I make a change in bot_update, it doesn't actually take effect until the CL rolls into build, which might take a bit, depending on if the roll is stuck.

Thoughts?
 

Comment 1 by estaab@chromium.org, Jun 16 2016

We could reorder the info so the most relevant parts are at the top, specifically which repos and what changes, e.g.

"
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bed5ced56d75a4a63d5b4e4241e4e9aa51e2de31

commit bed5ced56d75a4a63d5b4e4241e4e9aa51e2de31
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jun 15 10:46:14 2016

Roll recipes into "infra" (trivial).

from "build":
  https://crrev.com/ed82e67abdd60ce13f7bdae56d648bd62776f0e3 annotated_run: Use builder directory for temp. (dnj@google.com)
  https://crrev.com/3ff29095a3ded4744b3dc5c7367956471a9010ba libyuv: Set android_full_debug=1 in GYP_DEFINES for Android x86. (kjellander@chromium.org)
  https://crrev.com/98122d8810af966ebd7da62629c688c1ab6c8c9a remote_run: use /b as base directory for temporary files when available (phajdan.jr@chromium.org)

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

R=kjellander@chromium.org,dnj@google.com,fbarchard@chromium.org,phajdan.jr@chromium.org
BUG= 593999 , libyuv:602 , chromium:620158 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2068043003

[modify] https://crrev.com/bed5ced56d75a4a63d5b4e4241e4e9aa51e2de31/infra/config/recipes.cfg
"
I've started a document talking about the emails recipe developers receive as part of landing a CL. https://docs.google.com/document/d/1cme6lMGO7mMYK7LxO1SFwTKhwK7OrhfWUntKCq6wj04/edit

(feel free to ask for access to it if you don't have it)
Status: WontFix (was: Available)
See doc; moved into two separate bugs.

Comment 4 by jam@chromium.org, Jun 29 2016

Status: Available (was: WontFix)
laving this open to track two child bugs.

Comment 5 by jam@chromium.org, Jun 29 2016

Blockedon: 621746

Comment 6 by jam@chromium.org, Jun 29 2016

Blockedon: 621264

Comment 7 by jam@chromium.org, Sep 27 2016

Owner: benhenry@chromium.org
Status: Assigned (was: Available)
Ben: can you please assign this to owner of recipe roller? This is really spammy.
Owner: martiniss@chromium.org
"
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bed5ced56d75a4a63d5b4e4241e4e9aa51e2de31

commit bed5ced56d75a4a63d5b4e4241e4e9aa51e2de31
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jun 15 10:46:14 2016

Roll recipes into "infra" (trivial).

"build": https://chromium.googlesource.com/chromium/tools/build/+log/98122d8810af966ebd7da62629c688c1ab6c8c9a..ed82e67abdd60ce13f7bdae56d648bd62776f0e3

Confused? More info is at https://goo.gl/zkKdpD.

BUG=  593999  ,libyuv:602,chromium:620158

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2068043003

[modify] https://crrev.com/bed5ced56d75a4a63d5b4e4241e4e9aa51e2de31/infra/config/recipes.cfg
"

This is about the smallest we can make the commit message without losing important information. I'd prefer to keep all the separate changes being rolled in here, so it's easy to look at the roll and decide if something potentially dangerous gets rolled, but I can be persuaded to just have a link to a gitiles log if it's important to save lines in the message.

Comment 9 by jam@chromium.org, Oct 14 2016

maybe we'ere not talking about the same thing. I don't care what the commit message is. Just when I land a change in infra, I don't want the bug that it referenced to be updated so many times as it's rolled to different repos. Can we make the rolling changes not list bugs so that this doesn't happen? Or have them not update the bug system?
Status: Fixed (was: Assigned)

Sign in to add a comment