If CQ takes longer than the cycle time of the recipe roller, it will upload CLs which will fail to patch. This is at least annoying to me, and it does generate extra CL load. Does it matter more than that? Not exactly sure what the fix would be here. Here are some CLs which are symptoms of this: https://codereview.chromium.org/2075483002 https://codereview.chromium.org/2067243002 https://codereview.chromium.org/2070023002 https://codereview.chromium.org/2067243002 https://codereview.chromium.org/2070023002 https://codereview.chromium.org/2069153002 https://codereview.chromium.org/2073463002
This will be more of a problem with chromium included in the roller. The design of the roller doesn't account for projects with large CQ cycle times like chromium.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/289d03e1c8a859328990899eb8941344192f9ee1 commit 289d03e1c8a859328990899eb8941344192f9ee1 Author: phajdan.jr <phajdan.jr@chromium.org> Date: Tue Aug 16 15:21:06 2016 git-cl status: allow querying just the status of current CL BUG= 620494 Review-Url: https://codereview.chromium.org/2252473004 [modify] https://crrev.com/289d03e1c8a859328990899eb8941344192f9ee1/git_cl.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/59a9306a5c30de070c0c8a3daf68236a692c7f28 commit 59a9306a5c30de070c0c8a3daf68236a692c7f28 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Aug 16 15:27:07 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/289d03e1c8a859328990899eb8941344192f9ee1 git-cl status: allow querying just the status of current CL (phajdan.jr@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 620494 Recipe-Tryjob-Bypass-Reason: Autoroller Review-Url: https://codereview.chromium.org/2246403003 [modify] https://crrev.com/59a9306a5c30de070c0c8a3daf68236a692c7f28/infra/config/recipes.cfg
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/e0d0713d49c946497dd1302040540e4c7e9b90df commit e0d0713d49c946497dd1302040540e4c7e9b90df Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Aug 16 15:31:59 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/a81e90641d0ce4afa17b0d7743452cd48e77f8a6 commit a81e90641d0ce4afa17b0d7743452cd48e77f8a6 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Aug 16 15:46:45 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/59a9306a5c30de070c0c8a3daf68236a692c7f28 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/289d03e1c8a859328990899eb8941344192f9ee1 git-cl status: allow querying just the status of current CL (phajdan.jr@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 620494 Recipe-Tryjob-Bypass-Reason: Autoroller Review-Url: https://codereview.chromium.org/2255453002 [modify] https://crrev.com/a81e90641d0ce4afa17b0d7743452cd48e77f8a6/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/a3374fcfc45041bcb73d62a3dd7e9bc53df25a6a commit a3374fcfc45041bcb73d62a3dd7e9bc53df25a6a Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Tue Aug 16 19:21:41 2016 recipe_autoroller: record per-repo state BUG= 620494 Change-Id: I167c7947f63e991a0e40f02ffe55ce95ac22b419 Reviewed-on: https://chromium-review.googlesource.com/371239 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/a3374fcfc45041bcb73d62a3dd7e9bc53df25a6a/recipes/recipe_modules/recipe_autoroller/api.py [modify] https://crrev.com/a3374fcfc45041bcb73d62a3dd7e9bc53df25a6a/recipes/recipes/recipe_autoroller.expected/basic.json [modify] https://crrev.com/a3374fcfc45041bcb73d62a3dd7e9bc53df25a6a/recipes/recipes/recipe_autoroller.expected/nontrivial.json [modify] https://crrev.com/a3374fcfc45041bcb73d62a3dd7e9bc53df25a6a/recipes/recipes/recipe_autoroller.expected/previously_uploaded.json [modify] https://crrev.com/a3374fcfc45041bcb73d62a3dd7e9bc53df25a6a/recipes/recipes/recipe_autoroller.expected/previously_uploaded_match.json [modify] https://crrev.com/a3374fcfc45041bcb73d62a3dd7e9bc53df25a6a/recipes/recipes/recipe_autoroller.expected/with_auth.json
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/682a4d30330497d9f38858721fee4a1b89c1b1af commit 682a4d30330497d9f38858721fee4a1b89c1b1af Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Thu Aug 18 10:36:57 2016 recipe_autoroller: be aware of in-flight CLs; keep at most one open BUG= 620494 Change-Id: I4d81b6b4f26e05f0a67ffa7d113681d83715ae3a Reviewed-on: https://chromium-review.googlesource.com/371918 Commit-Queue: Paweł Hajdan Jr. <phajdan@google.com> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipe_modules/recipe_autoroller/api.py [modify] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipe_modules/recipe_autoroller/test_api.py [modify] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.expected/basic.json [modify] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.expected/empty.json [modify] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.expected/failed_upload.json [modify] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.expected/failure.json [modify] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.expected/nontrivial.json [modify] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.expected/previously_uploaded.json [modify] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.expected/previously_uploaded_match.json [add] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open.json [add] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_closed.json [add] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq.json [modify] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.expected/with_auth.json [modify] https://crrev.com/682a4d30330497d9f38858721fee4a1b89c1b1af/recipes/recipes/recipe_autoroller.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/e880323f0a199434c071cc107f8f0f4823b6b5d4 commit e880323f0a199434c071cc107f8f0f4823b6b5d4 Author: phajdan.jr <phajdan.jr@chromium.org> Date: Thu Aug 18 12:58:34 2016 recipe_autoroller: always set cwd to workdir TBR=emso,sergiyb,tandrii BUG= 620494 Review-Url: https://codereview.chromium.org/2257123003 [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipe_modules/recipe_autoroller/api.py [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipes/recipe_autoroller.expected/basic.json [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipes/recipe_autoroller.expected/empty.json [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipes/recipe_autoroller.expected/failed_upload.json [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipes/recipe_autoroller.expected/failure.json [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipes/recipe_autoroller.expected/nontrivial.json [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipes/recipe_autoroller.expected/previously_uploaded.json [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipes/recipe_autoroller.expected/previously_uploaded_match.json [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open.json [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_closed.json [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq.json [modify] https://crrev.com/e880323f0a199434c071cc107f8f0f4823b6b5d4/recipes/recipes/recipe_autoroller.expected/with_auth.json
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/42a8fd2ca80f47ddf0deae45671d6339d781efa8 commit 42a8fd2ca80f47ddf0deae45671d6339d781efa8 Author: phajdan.jr <phajdan.jr@chromium.org> Date: Thu Aug 18 13:17:58 2016 recipe_autoroller: pass cwd=workdir directly, not using a context TBR=emso,sergiyb,tandrii BUG= 620494 Review-Url: https://codereview.chromium.org/2249413005 [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipe_modules/recipe_autoroller/api.py [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipes/recipe_autoroller.expected/basic.json [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipes/recipe_autoroller.expected/empty.json [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipes/recipe_autoroller.expected/failed_upload.json [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipes/recipe_autoroller.expected/failure.json [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipes/recipe_autoroller.expected/nontrivial.json [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipes/recipe_autoroller.expected/previously_uploaded.json [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipes/recipe_autoroller.expected/previously_uploaded_match.json [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open.json [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_closed.json [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq.json [modify] https://crrev.com/42a8fd2ca80f47ddf0deae45671d6339d781efa8/recipes/recipes/recipe_autoroller.expected/with_auth.json
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/b2ac868746161f8dca8af1b86c592db93ccb85d4 commit b2ac868746161f8dca8af1b86c592db93ccb85d4 Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Thu Aug 18 17:52:30 2016 recipe_autoroller: remove no longer necessary git-cl set-commit After https://chromium-review.googlesource.com/c/371918/ the roller will retry a trivial roll. TBR=estaab, iannucci, martiniss BUG= 620494 , 600945 Change-Id: I75a86c414d8d76185b55f78f673bf5008114d533 Reviewed-on: https://chromium-review.googlesource.com/372623 Reviewed-by: Paweł Hajdan Jr. <phajdan@google.com> Commit-Queue: Paweł Hajdan Jr. <phajdan@google.com> [modify] https://crrev.com/b2ac868746161f8dca8af1b86c592db93ccb85d4/recipes/recipe_modules/recipe_autoroller/api.py [modify] https://crrev.com/b2ac868746161f8dca8af1b86c592db93ccb85d4/recipes/recipes/recipe_autoroller.expected/previously_uploaded_match.json
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/0474aa25ee10863e81849ed14675d5346d6e4fa8 commit 0474aa25ee10863e81849ed14675d5346d6e4fa8 Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Thu Aug 18 20:12:56 2016 recipe_autoroller: add auth flag to git cl status call TBR=estaab, iannucci, martiniss BUG= 620494 Change-Id: Iecc2912e2c390db6f5333707a2c019d85a1326cd Reviewed-on: https://chromium-review.googlesource.com/372739 Reviewed-by: Paweł Hajdan Jr. <phajdan@google.com> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan@google.com> [modify] https://crrev.com/0474aa25ee10863e81849ed14675d5346d6e4fa8/recipes/recipe_modules/recipe_autoroller/api.py [modify] https://crrev.com/0474aa25ee10863e81849ed14675d5346d6e4fa8/recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open.json [modify] https://crrev.com/0474aa25ee10863e81849ed14675d5346d6e4fa8/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_closed.json [modify] https://crrev.com/0474aa25ee10863e81849ed14675d5346d6e4fa8/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq.json
Comment 1 by martiniss@chromium.org
, Jun 29 2016