New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620482 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Alt-Svc: clear does not work with canonical hosts

Project Member Reported by rch@chromium.org, Jun 15 2016

Issue description

If a server emits Alt-Svc: clear, chrome correctly removes the Alt-Svc mapping for this host. However, if there is a canonical host for this server, that entry will still apply, thus defeating the clear. This makes it impossible to disable QUIC via Alt-Svc.
 

Comment 2 by rch@chromium.org, Jun 20 2016

Labels: Merge-Request-52

Comment 3 by tin...@google.com, Jun 20 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Labels: Needs-Feedback
@rch: Are there any manual steps to verify the above fix ?


Comment 5 by rch@chromium.org, Jun 22 2016

Weird, I merged this to m52 in https://codereview.chromium.org/2080803002/, but the bug was not updated. Did I do something wrong?

[m52] Make Alt-Svc: clear work with canonical hosts

BUG= 620482 
Review-Url: https://codereview.chromium.org/2069203003
Cr-Commit-Position: refs/heads/master@{#400060}
(cherry picked from commit 0c49a120616a28296dd457a023b63a65be94a15b)

Committed: https://chromium.googlesource.com/chromium/src/+/788b5d73328a22fc8233a48e00d5a804aa711153
  
Patch Set 1  (edit)

Comment 6 by rch@chromium.org, Jun 22 2016

ashejole: manual verification is a bit tricky because it requires a server to be emitting the Alt-Svc: clear header which is not currently happening. We noticed this when some of our servers needed to disable QUIC. But QUIC was re-enabled so we're not emitting this header any longer.
Cc: tinazh@chromium.org
I see the CL merged in to M52 branch on the branch tip.

https://chromium.googlesource.com/chromium/src.git/+log/refs/branch-heads/2743?n=1000

@Tina, can you please check why the bug is not updated with the merge information ?

Comment 8 by tin...@google.com, Jun 22 2016

Cc: shey...@chromium.org
The comment updating is done via bugdroig script (not merge script), + sheyang@ to take a further look.
Unfortunately bugdroid encountered an exception when processing this commit in all attempts:

SSLError: [Errno 1] _ssl.c:1429: error:1408F119:SSL routines:SSL3_GET_RECORD:decryption failed or bad record mac

The build is https://uberchromegw.corp.google.com/i/internal.infra.cron/builders/bugdroid/builds/5441/steps/bugdroid/logs/stdio

Comment 10 by tin...@google.com, Jun 22 2016

Labels: -Merge-Approved-52 merge-merged-2743
thanks for quick looking! 
Given not a way to backfill the commit via bugdroid, I've fixed the merge label.
rch@ pls feel free to copy your merge CL into this bug as well.

Labels: -Needs-Feedback

Comment 12 by rch@chromium.org, Aug 16 2016

Status: Fixed (was: Started)

Sign in to add a comment