New issue
Advanced search Search tips

Issue 620479 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Improve memory footprint for background download resumption.

Project Member Reported by qin...@chromium.org, Jun 15 2016

Issue description

When resuming a download in background, only the browser process is needed.

On a nexus 6P, launching the browser process takes a pss of 40.2 MB and private dirty of 13.7MB.
The numbers are 11MB and 7.7MB for android downloadmanager, and 13.6MB and 6.5MB for UC download process.

We need to improve our memory footprint so it won't impact other running apps


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d2f27dd1d80ce3a4c295e9551d16d91329f3e9e

commit 9d2f27dd1d80ce3a4c295e9551d16d91329f3e9e
Author: qinmin <qinmin@chromium.org>
Date: Fri Jun 17 05:45:01 2016

Format remaining download time in java code

When displaying the remaining download time, ui::TimeFormat::Simple() is
called.
It calls into third_party/icu, and is quite expensive, takes 70kB from memory dump.
This CL adds a simple java method to replace that call.
The Java method is similar to
android.java.text.Formatter.formatShortElapsedTime().
And it should generate the same output string as
ui::TimeFormat::Simple().

BUG=620479

Review-Url: https://codereview.chromium.org/2070713002
Cr-Commit-Position: refs/heads/master@{#400370}

[modify] https://crrev.com/9d2f27dd1d80ce3a4c295e9551d16d91329f3e9e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/9d2f27dd1d80ce3a4c295e9551d16d91329f3e9e/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/9d2f27dd1d80ce3a4c295e9551d16d91329f3e9e/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
[modify] https://crrev.com/9d2f27dd1d80ce3a4c295e9551d16d91329f3e9e/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
[modify] https://crrev.com/9d2f27dd1d80ce3a4c295e9551d16d91329f3e9e/ui/android/java/src/org/chromium/ui/base/LocalizationUtils.java

Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8569a7cd8c3cb6f9cd22467e084860721ceadd7

commit c8569a7cd8c3cb6f9cd22467e084860721ceadd7
Author: qinmin <qinmin@chromium.org>
Date: Thu Jul 07 00:33:39 2016

Intiialize AudioManager and related class lazily

AudioManager is created when browser process is created.
However, for background download resumption, we don't need AudioManager
for download to resume.
Creating the AudioManager takes about 10KB of memory.
This is only needed when the first renderer is created.
This CL delays AudioManager creation until it is first referenced.
This also involves some other classes that depends on AudioManager.

BUG=620479

Review-Url: https://codereview.chromium.org/2077983003
Cr-Commit-Position: refs/heads/master@{#404014}

[modify] https://crrev.com/c8569a7cd8c3cb6f9cd22467e084860721ceadd7/content/browser/browser_main_loop.cc
[modify] https://crrev.com/c8569a7cd8c3cb6f9cd22467e084860721ceadd7/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/c8569a7cd8c3cb6f9cd22467e084860721ceadd7/content/browser/speech/speech_recognition_browsertest.cc
[modify] https://crrev.com/c8569a7cd8c3cb6f9cd22467e084860721ceadd7/media/audio/android/audio_manager_android.cc
[modify] https://crrev.com/c8569a7cd8c3cb6f9cd22467e084860721ceadd7/media/audio/android/audio_manager_android.h
[modify] https://crrev.com/c8569a7cd8c3cb6f9cd22467e084860721ceadd7/media/audio/audio_manager.cc
[modify] https://crrev.com/c8569a7cd8c3cb6f9cd22467e084860721ceadd7/media/audio/audio_manager.h

Sign in to add a comment