New issue
Advanced search Search tips

Issue 620466 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 620852
issue 622101



Sign in to add a comment

Add UMA tracking size of predictor DB on startup

Project Member Reported by csharrison@chromium.org, Jun 15 2016

Issue description

This is useful for tracking both the memory cost from this feature, as well as how often the DB is completely trashed on unclean shutdown.

It may be worthwhile to include size in bytes as well as entry count. There are ideas floating around that would require storing full URLs instead of just domains.
 
mmenke@, I'll try to get to this next week. Feel free to take from me if you have cycles.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0da3d1035c13406324b7037a7138790b783e8f5

commit d0da3d1035c13406324b7037a7138790b783e8f5
Author: csharrison <csharrison@chromium.org>
Date: Tue Jun 21 03:40:39 2016

Log predictor database size on startup

This patch adds UMA about the predictor's database size when it is first
initialized. This will track cases when the pref writing policy fails due
to unclean shutdown.

Additionally, the metric will be useful for determining how much of a
memory hog the predictor is, with its opaque trimming mechanism.

BUG= 620466 

Review-Url: https://codereview.chromium.org/2082653003
Cr-Commit-Position: refs/heads/master@{#400884}

[modify] https://crrev.com/d0da3d1035c13406324b7037a7138790b783e8f5/chrome/browser/net/predictor.cc
[modify] https://crrev.com/d0da3d1035c13406324b7037a7138790b783e8f5/chrome/browser/net/predictor.h
[modify] https://crrev.com/d0da3d1035c13406324b7037a7138790b783e8f5/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Comment 4 by mmenke@chromium.org, Jun 22 2016

Blocking: 620852

Comment 5 by mmenke@chromium.org, Jun 22 2016

Blocking: 622101

Sign in to add a comment