New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620456 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Use other robhogan account instead.
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 24826



Sign in to add a comment

When tables are nested, the headers for the respective tables overlap on the 2nd printed page.

Project Member Reported by robhogan@chromium.org, Jun 15 2016

Issue description

When tables are nested, the headers for the respective tables overlap on the 2nd page. Example attached.
Please be aware - this is going to break a lot of pages. I prefer the old behavior which at least didn't have any overlaps.
 
overlap.html
3.1 KB View Download
Cc: leor.ba...@gmail.com
Owner: robhogan@chromium.org
Status: Assigned (was: Unconfirmed)
Blocking: 24826
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23cfc9840611a905a979be77cf6cee31519c542e

commit 23cfc9840611a905a979be77cf6cee31519c542e
Author: robhogan <robhogan@gmail.com>
Date: Wed Jun 29 22:09:09 2016

Handle nested theads correctly when paginated

When paginated, repeat nested theads at the top of each page - replicating the
way they look on the first page bar any spacing between them applied by content.

We don't try to replicate any cell padding in the nested repeating theads, that
would be a lot of work for not much gain.

BUG= 620456 

Review-Url: https://codereview.chromium.org/2079603002
Cr-Commit-Position: refs/heads/master@{#402943}

[add] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-2-expected.html
[add] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-2.html
[add] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-3-expected.html
[add] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-3.html
[add] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-4-expected.html
[add] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-4.html
[add] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-expected.html
[add] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead.html
[modify] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/Source/core/layout/LayoutState.cpp
[modify] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/Source/core/layout/LayoutState.h
[modify] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/Source/core/layout/LayoutTableSection.h
[modify] https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

Awesome. Printout looks fine.

Thanks!
Labels: TE-Verified-53.0.2785.8 TE-Verified-M53
Verified the issue on Latest Dev# 53.0.2785.8 on Windows, Mac and Linux and is working as intended.
Hence adding TE-Verified-Labels.
Thank You.
This issue seems to be related to  issue 631222 
Status: Fixed (was: Assigned)

Sign in to add a comment