New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620448 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

kitchen: reuse "remote" subcommand in recipe_engine

Project Member Reported by no...@chromium.org, Jun 15 2016

Issue description

Comment 1 by no...@chromium.org, Jun 16 2016

currently kitchen annotates checking out git repo, so milo sees kitchen's work as "recipe bootstrap" step: e.g. https://luci-milo.appspot.com/swarming/prod/2f73da2386607e10

recipe engine should do that too before we can replace kitchen with recipe engine. Pawel, please consider adding this feature.

Comment 2 by no...@chromium.org, Jun 23 2016

Components: -Infra>Platform Infra>Platform>Buildbucket>Swarmbucket
Owner: no...@chromium.org
Status: Assigned (was: Untriaged)
Summary: kitchen: reuse "remote" subcommand in recipe_engine (was: replace kitchen with "remote run" in recipe_engine)
> #1

our build machine fleet is heterogeneous. in particular gce machines have credentials stored on metadata server and other machines keep credentials on disk. There must be a bootstrap program that glues everything together. kitchen can be that program.

it means that kitchen will use "remote" subcommand to run a recipe and may do other things, so there is no need to print annotations in "remote" subcommand

Comment 3 by no...@chromium.org, Jun 24 2016

Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 5 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Type-Bug

Comment 6 by no...@chromium.org, Oct 13 2016

Labels: -Pri-2 Pri-1
Owner: no...@chromium.org
Status: Started (was: Available)
it is about time
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ed066c2321983cc8184c3382839ea56508c43345

commit ed066c2321983cc8184c3382839ea56508c43345
Author: Nodir Turakulov <nodir@chromium.org>
Date: Thu Oct 20 23:21:05 2016

kitchen: use recipes.py remote

add -recipe-engine-path flag. If specified, run a recipe using remote
subcommand. The recipe engine will be depoyed on bots via swarming-cipd
integration.

Future Cl will remove the old code path.

R=martiniss@chromium.org, phajdan.jr@chromium.org
BUG= 620448 

Change-Id: Idd7f0f08c0aaafa049ca55f3ddf6b00545f808dd
Reviewed-on: https://chromium-review.googlesource.com/401438
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/ed066c2321983cc8184c3382839ea56508c43345/go/src/infra/tools/kitchen/cook.go
[modify] https://crrev.com/ed066c2321983cc8184c3382839ea56508c43345/go/src/infra/tools/kitchen/recipe.go

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/66242081a7e3db08ed5b1e42e7ecc83aa349fec3

commit 66242081a7e3db08ed5b1e42e7ecc83aa349fec3
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Oct 21 05:22:11 2016

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/e10e3793f043d5c3851598208f69600b25e95fd5

commit e10e3793f043d5c3851598208f69600b25e95fd5
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Oct 21 16:03:27 2016

Labels: Milestone-ChromiumTryBlockers
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 22 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/be5219b473acb3ad4f65bd1fd43326cbd3cc55be

commit be5219b473acb3ad4f65bd1fd43326cbd3cc55be
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Oct 22 03:09:38 2016

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/3af0e262030933f6b8c6049ff32a661d2f8ed5ad

commit 3af0e262030933f6b8c6049ff32a661d2f8ed5ad
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 01 21:47:12 2016

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/7c5be1285f5d682d5c3f6620a212458e6f528b62

commit 7c5be1285f5d682d5c3f6620a212458e6f528b62
Author: Nodir Turakulov <nodir@chromium.org>
Date: Tue Nov 01 23:48:07 2016

kitchen: require -recipe-engine-path

Also remove code that was used only if recipe engine path is not
specified

R=martiniss@chromium.org
BUG= 620448 

Change-Id: Ib2dff4b4e08bf8547197364ca421787614e26768
Reviewed-on: https://chromium-review.googlesource.com/405828
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/7c5be1285f5d682d5c3f6620a212458e6f528b62/go/src/infra/tools/kitchen/cook.go
[delete] https://crrev.com/445055304d918b175f2a3adc668f6c906c11fef3/go/src/infra/tools/kitchen/recipe.go

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/7c5be1285f5d682d5c3f6620a212458e6f528b62

commit 7c5be1285f5d682d5c3f6620a212458e6f528b62
Author: Nodir Turakulov <nodir@chromium.org>
Date: Tue Nov 01 23:48:07 2016

kitchen: require -recipe-engine-path

Also remove code that was used only if recipe engine path is not
specified

R=martiniss@chromium.org
BUG= 620448 

Change-Id: Ib2dff4b4e08bf8547197364ca421787614e26768
Reviewed-on: https://chromium-review.googlesource.com/405828
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/7c5be1285f5d682d5c3f6620a212458e6f528b62/go/src/infra/tools/kitchen/cook.go
[delete] https://crrev.com/445055304d918b175f2a3adc668f6c906c11fef3/go/src/infra/tools/kitchen/recipe.go

Status: Fixed (was: Started)
kitchen now always uses `recipes.py remote`

however! it does not use gitiles API because some recipes in build.git depend on python scripts outside of the recipe package
Components: Infra>Platform>Buildbucket

Sign in to add a comment