"Your Internet Connection is Being Controlled" bubble pointing at bookmark star. |
||||||||||
Issue descriptionChrome 53.0.2768.0 OSX 10.11.5 What steps will reproduce the problem? (1) I have Chrome Canary with the default on-toolbar Google corp extensions (Watchword, BeyondCorp) hidden in the menu. (2) I did a routine Chrome Canary upgrade to 53.0.2768.0 (3) A bubble appeared, with the heading "Your Internet Connection is Being Controlled". What is the expected output? The bubble makes sense. What do you see instead? The bubble isn't pointing at an extension icon, nor does it mention the name of the extension. Given the lack of attribution, the content of the message is extra-scary. I assume it's trying to point at an extension icon (possibly BeyondCorp) that isn't shown. meacer@, could you reassign to the appropriate person? (Note: I'm not view-restricting this bug, since it is public that Google has Watchword and BeyondCorp.)
,
Jun 15 2016
I think ainslie@ also saw this bug, but I've been unable to reproduce on my mac. Which type of mac are you using? I wonder if it's device-specific (*shudders at the thought*).
,
Jun 15 2016
MacBook Pro (Retina, 15-inch, Mid 2014) (2.8 GHz Intel Core i7, 16 GB 1600 MHz DDR3, NVIDIA GeForce GT 750M 2048 MB) The most logical thing is that the extension icon is staying hidden when it should be showing. However, there are other circumstances where an extension is pulled out from the menu (e.g. invoking the bubble action for an extension with a hidden icon) that work correctly.
,
Jun 15 2016
And that's what I see on my mac - the extension gets pulled out, highlighted, and the bubble points to it. Hmm...
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1 commit af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Tue Jun 21 00:16:00 2016 [Extensions UI] Handle multiple warning bubbles racing to show If multiple windows all tried to create a warning bubble at the same time, it would be handled incorrectly. Though only one bubble would show, the others would be destructed and potentially undo the work the first did (like highlighting extensions on the toolbar). Instead, link the warning bubbles with the toolbar model, which is per- profile and handles the highlighting logic. Also add a regression test, and beef up some existing tests. BUG= 620434 Review-Url: https://codereview.chromium.org/2076093004 Cr-Commit-Position: refs/heads/master@{#400849} [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/extensions/extension_message_bubble_controller.cc [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/extensions/extension_message_bubble_controller.h [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/ui/extensions/settings_api_bubble_helpers.cc [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/ui/toolbar/toolbar_actions_bar.cc [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/ui/toolbar/toolbar_actions_bar.h [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/ui/toolbar/toolbar_actions_model.cc [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/ui/toolbar/toolbar_actions_model.h [modify] https://crrev.com/af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
,
Jun 21 2016
,
Jun 21 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 22 2016
Update: looks like that patch may have caused a crash, so gonna fix that before I merge.
,
Jun 23 2016
rdevlin.cronin@ : Could you please let us know the required steps if this can be verified from TE end.
,
Jun 23 2016
Repro steps: On mac: - load an unpacked extension - hide the extension's toolbar action in the chrome menu (right click, hide in chrome menu) - Open two browser windows - in chrome://settings, select "Continue where I left off" for start up behavior. - Shut down chrome - Reopen Expected behavior: the extension should highlight, and a bubble should appear a few seconds later warning about developer mode extensions. The bubble should be pointing to the extension toolbar action. Before fix: the bubble would point at the bookmark star.
,
Jun 25 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 27 2016
rdevlin.cronin@, please confirm the behavior in # 11. If everything is verified correctly on ToT as per # 11, please also merge the CL in to M52 branch by EOD so that it gets picked up for beta promotion scheduled this wednesday.
,
Jun 29 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 29 2016
@11 - that's actually a different bubble. Instead of installing a packed extension from off-store, to repro this you can install an unpacked extension. That is, load an extension from chrome://extensions by clicking on the "Load unpacked extension" button.
,
Jun 29 2016
Attached a screencast of what it should look like.
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/182a245e61779ac581e91c5ddb6841fb76595f01 commit 182a245e61779ac581e91c5ddb6841fb76595f01 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Jun 29 17:13:51 2016 [Extensions UI] Handle multiple warning bubbles racing to show If multiple windows all tried to create a warning bubble at the same time, it would be handled incorrectly. Though only one bubble would show, the others would be destructed and potentially undo the work the first did (like highlighting extensions on the toolbar). Instead, link the warning bubbles with the toolbar model, which is per- profile and handles the highlighting logic. Also add a regression test, and beef up some existing tests. BUG= 620434 Review-Url: https://codereview.chromium.org/2076093004 Cr-Commit-Position: refs/heads/master@{#400849} (cherry picked from commit af64c8cb4de48a580b04fe266e6f6a0c4c14e4d1) [Extensions UI] Fix a crash when clicking on a bubble's learn more Clicking on a bubble's learn more link causes a tab to open, which in turn causes the bubble to be cleaned up (as part of losing focus to the new tab). Fix the order so that we clean up before opening the new tab and add a regression test. Also add end-to-end tests for clicking on the action and dismiss buttons. BUG=622117 Review-Url: https://codereview.chromium.org/2086193002 Cr-Commit-Position: refs/heads/master@{#401412} (cherry picked from commit bb826f1bd289d9147c4e0b630831b0ab6ae81afd) TBR=avi@chromium.org TBR=finnur@chromium.org Manual Merge Note: Merging the fix for crbug.com/620434 along with the fix for the crash related to that patch. Review URL: https://codereview.chromium.org/2105393002 . Cr-Commit-Position: refs/branch-heads/2743@{#527} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/extensions/extension_message_bubble_controller.cc [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/extensions/extension_message_bubble_controller.h [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/ui/extensions/settings_api_bubble_helpers.cc [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/ui/toolbar/toolbar_actions_bar.cc [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/ui/toolbar/toolbar_actions_bar.h [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/ui/toolbar/toolbar_actions_model.cc [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/ui/toolbar/toolbar_actions_model.h [modify] https://crrev.com/182a245e61779ac581e91c5ddb6841fb76595f01/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
,
Jun 30 2016
Thanks for the update rdevlin.cronin@, verified the issue on Mac 10.11.5 using 53.0.2783.2 and 52.0.2743.60 and its working fine as intended. Please find the attached screen cast for the same. Added respective TE-Verified labels. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by mea...@chromium.org
, Jun 15 2016Owner: rdevlin....@chromium.org