vp9 fullscreen power regression when Material is enabled |
||||||||
Issue descriptionRunning fullscreen vp9 on M52 uses much more power than M51. The power usage is: - M51: 2.247553 - M52: 3.148361 This is roughly fixed by fullscreen low power mode, but only when we hit that mode.
,
Jun 15 2016
Checked this with YouTube, and the power difference in fullscreen is: M51: 3.72 W M52: 5.27 W Adding RBS keyword.
,
Jun 16 2016
,
Jun 16 2016
Ticking "Reduce transparency" in accessibility settings makes the regression go away. Perhaps we can dynamically pull out the NSVisualEffectView when we're in fullscreen? Of note is that in M53, the fullscreen low power mode fixes this (but only sometimes -- only when we have no controls on the screen, etc).
,
Jun 16 2016
It might work to just set the NSVisualEffectView's state to NSVisualEffectStateInactive when the window is in fullscreen mode.
,
Jun 16 2016
Issue 617275 has been merged into this issue.
,
Jun 16 2016
This is H264 as well -- it just so happens that there was a significant improvement at the same time as the regression Fullscreen 720p30fps (avengers) H264 power: M51: 2.455787 W M51 RT: 2.409220 W TOT: 2.664256 W TOT RT: 1.998814 W Windowed power usage is unaffected by this. Testing the NSVisualEffectStateInactive behavior now.
,
Jun 16 2016
> Windowed power usage is unaffected by this. That was going to be my next question.
,
Jun 16 2016
A friendly reminder that M52 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by July 12. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/208098685cf35d3bb995cb365d204f0a65381ad3 commit 208098685cf35d3bb995cb365d204f0a65381ad3 Author: ccameron <ccameron@chromium.org> Date: Fri Jun 17 00:08:14 2016 Mac: Disable visual effects when fullscreen These effects result in substantially higher power consumption. Make the change in didEnter/willExit (as opposed to adjustUIForExiting/ ExitingFullscreen) because we want the effect to go away only while the window is fullscreen (not during the transition). BUG= 620433 Review-Url: https://codereview.chromium.org/2071973002 Cr-Commit-Position: refs/heads/master@{#400308} [modify] https://crrev.com/208098685cf35d3bb995cb365d204f0a65381ad3/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/208098685cf35d3bb995cb365d204f0a65381ad3/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h [modify] https://crrev.com/208098685cf35d3bb995cb365d204f0a65381ad3/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm [modify] https://crrev.com/208098685cf35d3bb995cb365d204f0a65381ad3/chrome/browser/ui/cocoa/tabs/tab_strip_view.h [modify] https://crrev.com/208098685cf35d3bb995cb365d204f0a65381ad3/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
,
Jun 17 2016
Adding merge request for M52.
,
Jun 17 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78e7db6652e8a9ffd977d97314d393cb180ed4d0 commit 78e7db6652e8a9ffd977d97314d393cb180ed4d0 Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Jun 17 23:55:02 2016 Mac: Disable visual effects when fullscreen These effects result in substantially higher power consumption. Make the change in didEnter/willExit (as opposed to adjustUIForExiting/ ExitingFullscreen) because we want the effect to go away only while the window is fullscreen (not during the transition). BUG= 620433 Review-Url: https://codereview.chromium.org/2071973002 Cr-Commit-Position: refs/heads/master@{#400308} (cherry picked from commit 208098685cf35d3bb995cb365d204f0a65381ad3) Review URL: https://codereview.chromium.org/2074933006 . Cr-Commit-Position: refs/branch-heads/2743@{#388} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/78e7db6652e8a9ffd977d97314d393cb180ed4d0/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/78e7db6652e8a9ffd977d97314d393cb180ed4d0/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h [modify] https://crrev.com/78e7db6652e8a9ffd977d97314d393cb180ed4d0/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm [modify] https://crrev.com/78e7db6652e8a9ffd977d97314d393cb180ed4d0/chrome/browser/ui/cocoa/tabs/tab_strip_view.h [modify] https://crrev.com/78e7db6652e8a9ffd977d97314d393cb180ed4d0/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
,
Jun 21 2016
,
Jun 22 2016
ccameron@, can this be tested manually so that we can verify the fix at our end ? If so, please let us know the steps to verify this issue.
,
Jun 22 2016
I've manually tested this (it requires power testing, which can be a particular setup). |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ccameron@chromium.org
, Jun 15 2016