Issue metadata
Sign in to add a comment
|
Make emoji look good without explicit "Segoe UI Emoji" assignment
Reported by
tj.vant...@gmail.com,
Jun 15 2016
|
||||||||||||||||||||
Issue description
Chrome Version : 51.0.2704.84
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Firefox on Windows: PASS (47.0)
Edge: FAIL (20.10240.16384.0)
What steps will reproduce the problem?
(1) Render an emoji in Chrome on Windows, like
,
Jun 16 2016
Actually I misspoke a bit. In Edge you can get colorful emoji by assigning `font-family: "Segoe UI Emoji"`, but in Chrome for Windows I cannot get colorful emoji regardless of the technique that I use.
,
Jun 16 2016
,
Jun 21 2016
Issue 459056 and related code should ensure that the emoji font is used for emoji when appropriate, while issue 333011 implements support for rendering color emoji in content (currently in canary/dev, and will go to beta/stable in M53). So, explicitly setting the emoji font family definitely should not be needed. If you are finding that it is still needed, please include a repro: ideally as a self-contained html file, or as a link if that is not possible. Issue 617376 deals with color emoji in Chrome UI (tabstrip, bookmark bar, url bar, etc) so I don't think that's what this bug is talking about.
,
Jun 21 2016
I should also note that color emoji are only supported on Win8.1 and later. If you are testing on Win7 it is expected that all emoji render only in B/W.
,
Jun 22 2016
Just to note I checked and emoji look great in Canary even without an explicit font assignment, so I'm all set here. Thanks for all your work on this; it's much appreciated. I would include an emoji to show my gratification except it seems to break this bug tracker, which I find somewhat ironic. Anyways, have a good one!
,
Oct 4 2016
Is there a way to get this working when running with the `--no-sandbox` flag? It looks like it still shows box characters for the test page when Chrome is run with this option. https://cs.chromium.org/chromium/src/content/renderer/renderer_main_platform_delegate_win.cc?l=56
,
Oct 4 2016
#9: quick test indicates it should just be a matter of moving the initialize call outside the if-block. I'm curious though if there's a particular reason why you are running with the --no-sandbox flag?
,
Oct 4 2016
#10: I'm trying to enable support for this in Electron which runs renderer processes with `--no-sandbox`, https://github.com/electron/electron/issues/7334 Is there any danger in calling InitializeDWriteFontProxy with no sandbox? I wasn't sure why this was originally behind the sandbox option check. We could patch our version of chromium to move that call outside the if block if it is safe to do. Thanks for replying.
,
Oct 4 2016
Created https://codereview.chromium.org/2387373003/ for the fix. Please open a new bug and assign to me so we can track it.
,
Oct 4 2016
Opened https://bugs.chromium.org/p/chromium/issues/detail?id=652898, I'm not sure I'm able to assign it directly to you though, thanks for the quick fix. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by tj.vant...@gmail.com
, Jun 15 2016