New issue
Advanced search Search tips

Issue 620417 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

"Inspect Popup" menu option present for extensions with synthesized actions

Project Member Reported by rdevlin....@chromium.org, Jun 15 2016

Issue description

Extensions that don't have a page or browser action specified get a synthesized action.  However, it doesn't make sense to add the "Inspect Poppup" menu item, since it will never be enabled for these extensions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7535915c038056073769a5c742cc02781b7bec49

commit 7535915c038056073769a5c742cc02781b7bec49
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed Jun 15 23:04:40 2016

[Extensions] Omit the "Inspect popup" menu item for synthesized actions

Extensions that don't specify a page or browser action with have a page
action synthesized. However, these actions will never have an associated
popup, so it doesn't make sense to add the menu item.

BUG= 620417 

Review-Url: https://codereview.chromium.org/2068313002
Cr-Commit-Position: refs/heads/master@{#400037}

[modify] https://crrev.com/7535915c038056073769a5c742cc02781b7bec49/chrome/browser/extensions/extension_context_menu_model.cc
[modify] https://crrev.com/7535915c038056073769a5c742cc02781b7bec49/chrome/browser/extensions/extension_context_menu_model_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment