Issue metadata
Sign in to add a comment
|
infra presubmit broken |
||||||||||||||||||||||||
Issue descriptionI tried to make a small change here https://codereview.chromium.org/2067653002/ but the presubmit was failing on bots. After much confusion this nop CL also fails https://codereview.chromium.org/2069983004. Presumably this ought to be blocking all submissions, but I guess it doesn't always get run or something? ====================================================================== FAIL: testMove (__main__.GitCheckout) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/checkout_test.py", line 321, in testMove self.assertEquals(expected, out) AssertionError: Lists differ: ['A\tchromeos/views/webui_menu... != ['R067\tchromeos/views/DOMui_m... First differing element 0: A chromeos/views/webui_menu_widget.h R067 chromeos/views/DOMui_menu_widget.h chromeos/views/webui_menu_widget.h First list contains 1 additional elements. First extra element 1: D chromeos/views/DOMui_menu_widget.h + ['R067\tchromeos/views/DOMui_menu_widget.h\tchromeos/views/webui_menu_widget.h'] - ['A\tchromeos/views/webui_menu_widget.h', - 'D\tchromeos/views/DOMui_menu_widget.h'] ---------------------------------------------------------------------- Ran 4 tests in 1.916s FAILED (failures=1, skipped=1) Found unpatched files: ['chromeos/views/DOMui_menu_widget.h'] Presubmit checks took 126.3s to calculate. step returned non-zero exit code: 1 @@@STEP_FAILURE@@@ @@@SET_BUILD_PROPERTY@failure_hash@"055d88323f13b6174c79a757eaaf150fa3ef7d2a"@@@
,
Jun 15 2016
git version is 2.9.0 on bots per https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/614/steps/presubmit/logs/stdio and there is indeed some extra junk in the output.
,
Jun 15 2016
And... https://git-scm.com/download/mac there's not even binaries for 2.9.0 :/
,
Jun 15 2016
Ah, tandrii found this too https://bugs.chromium.org/p/chromium/issues/detail?id=619959. :( |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by scottmg@chromium.org
, Jun 15 2016