If outline-color: invert is not supported, it should compute to currentColor
Reported by
impressi...@gmail.com,
Jun 15 2016
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.84 Safari/537.36 Example URL: https://jsbin.com/qatepo/edit?html,css,output Steps to reproduce the problem: 1. Set an element's color using the color property in the CSS 2. Set an element's outline-color property to "invert" (ensuring also that the outline-width and outline-style is set) What is the expected behavior? The outline color should compute to the currentColor. What went wrong? The outline color computes to transparent - rgba(0,0,0,0). Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? No Does this work in other browsers? No Firefox 47 Chrome version: 51.0.2704.84 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 21.0 r0 The spec explains: > If the UA does not support the invert value then it must reject that value at parse-time, and the initial value of the outline-color property is the currentColor keyword. See: https://drafts.csswg.org/css-ui-3/#outline-color
,
Jun 17 2016
,
Jun 17 2016
,
Jun 20 2016
Thanks for the report. CL: https://chromium.googlesource.com/chromium/src/+log/39.0.2150.0..39.0.2151.0?pretty=fuller&n=10000 Blink CL: https://chromium.googlesource.com/chromium/blink/+log/09bd97099a92cf983363f8db6c6c2178b0cd7c6a..dc9e4a55d37d35200e733b12fadca553f353123d https://chromium.googlesource.com/chromium/blink/+log/86ce4af33b763b24cf2365d8cd19a2ebade676c3..09bd97099a92cf983363f8db6c6c2178b0cd7c6a Good Build: 39.0.2150.0 Bad Build: 39.0.2151.0 Not able to get the version information using omahaproxy, showing this message, hence provided manual bisect info "The requested version information could not be found at this time. An exception has been logged for the maintainer." Unable to find the exact culprit, requesting Dev team to help. Note: Able to repro using Chrome 51.0.2704.103, Beta 52.0.2743.41, Dev 53.0.2767.4 and Canary 53.0.2772.0 on Win7, Mac OS X 10.11.5, Ubuntu 14.04 Attached screenshot for reference, please check and let me know if I am missing something.
,
Jun 20 2016
,
Jun 20 2016
,
Jun 20 2016
The spec reference is right, but the test-case is wrong. We should not make invert currentColor, but drop declarations with the invert keyword. The reference to the initial value being currentColor is about the initial value in the spec which is "invert".
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e71d3d9b4687a515e0aca0089a46cc8df84ce84 commit 1e71d3d9b4687a515e0aca0089a46cc8df84ce84 Author: rune <rune@opera.com> Date: Tue Jun 21 05:49:29 2016 Reject invert for outline-color at parse time. We don't support invert as outline-color, so we should drop it at parse time as per spec[1]. Added test to check that the initial value of outline-color is the computed value of currentColor. Gecko also drops declarations with invert for outline-color. [1] https://drafts.csswg.org/css2/ui.html#value-def-invert R=timloh@chromium.org BUG= 620399 Review-Url: https://codereview.chromium.org/2081633002 Cr-Commit-Position: refs/heads/master@{#400902} [modify] https://crrev.com/1e71d3d9b4687a515e0aca0089a46cc8df84ce84/third_party/WebKit/LayoutTests/fast/css/outline-currentcolor-expected.txt [modify] https://crrev.com/1e71d3d9b4687a515e0aca0089a46cc8df84ce84/third_party/WebKit/LayoutTests/fast/css/outline-currentcolor.html [add] https://crrev.com/1e71d3d9b4687a515e0aca0089a46cc8df84ce84/third_party/WebKit/LayoutTests/fast/css/outline-invert.html [modify] https://crrev.com/1e71d3d9b4687a515e0aca0089a46cc8df84ce84/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/1e71d3d9b4687a515e0aca0089a46cc8df84ce84/third_party/WebKit/Source/core/dom/TextLinkColors.cpp
,
Jun 21 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by impressi...@gmail.com
, Jun 15 2016