New issue
Advanced search Search tips

Issue 620385 link

Starred by 6 users
Status: Fixed
Owner:
mark@chromium.org
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocked on:
issue 620381


Sign in to add a comment

Install from .dmg: Dock restart not working on 10.12

Project Member Reported by mark@chromium.org, Jun 15 2016 
After  bug 620381  is fixed, install-from-dmg will work on 10.12, but the dock restart (https://chromium.googlesource.com/chromium/src/+/574f09c11f5a366b059d0992c180543697666c8a/chrome/browser/mac/dock.mm#126) does not.

In 10.12, Dock.app no longer terminates upon receipt of SIGHUP. SIGTERM will work.

Comment 1 by mark@chromium.org, Jun 21 2016

Blockedon: 620381
Blocked on  bug 620381  because there is no install-from-dmg on 10.12 at all until the dmg is signed.

Comment 2 by mark@chromium.org, Jun 28 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2108703002/
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/339ee572c21fa708c4eec78ecd2950b6263165e4

commit 339ee572c21fa708c4eec78ecd2950b6263165e4
Author: mark <mark@chromium.org>
Date: Tue Jun 28 22:25:15 2016

mac: Send SIGTERM instead of SIGHUP to restart Dock

Dock swallows SIGHUP as of macOS 10.12. SIGTERM still works.

BUG= 620385 

Review-Url: https://codereview.chromium.org/2108703002
Cr-Commit-Position: refs/heads/master@{#402574}

[modify] https://crrev.com/339ee572c21fa708c4eec78ecd2950b6263165e4/chrome/browser/mac/dock.mm

Comment 4 by mark@chromium.org, Jun 28 2016

Status: Fixed (was: Started)

Comment 5 by mark@chromium.org, Jul 8 2016

Labels: M-53
►

Sign in to add a comment