New issue
Advanced search Search tips

Issue 620371 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Proguard optimizations

Project Member Reported by smaier@chromium.org, Jun 15 2016

Issue description

Generic bug for proguard flags that are found which are beneficial to be turned on/off.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e79c0ef8b14860f90bf838596c8bad9faf2c7ba1

commit e79c0ef8b14860f90bf838596c8bad9faf2c7ba1
Author: smaier <smaier@chromium.org>
Date: Mon Jun 20 16:03:09 2016

Proguard: Logging stripped and allowaccessmodification turned on

BUG= 620371 

Review-Url: https://codereview.chromium.org/2067303002
Cr-Commit-Position: refs/heads/master@{#400692}

[modify] https://crrev.com/e79c0ef8b14860f90bf838596c8bad9faf2c7ba1/chrome/android/java/proguard.flags

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/2d8e46f62869097c447480592851464f09ebf965

commit 2d8e46f62869097c447480592851464f09ebf965
Author: Sam Maier <smaier@google.com>
Date: Thu Jun 23 13:59:32 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/4c9e68f1babf54ab204de62cda5b2625bd80bd77

commit 4c9e68f1babf54ab204de62cda5b2625bd80bd77
Author: Sam Maier <smaier@google.com>
Date: Fri Jun 24 15:19:49 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc1a80d5d329dd4a1cce9886cadf85100f1edcb4

commit fc1a80d5d329dd4a1cce9886cadf85100f1edcb4
Author: smaier <smaier@chromium.org>
Date: Thu Jul 28 20:28:08 2016

Running 3 ProgGuard optimization passes.

This increases release build time by 30s, reduces our .dex size by 33k,
and saves us 2k memory per process.

BUG= 620371 

Review-Url: https://codereview.chromium.org/2166813002
Cr-Commit-Position: refs/heads/master@{#408464}

[modify] https://crrev.com/fc1a80d5d329dd4a1cce9886cadf85100f1edcb4/base/android/base_proguard_config.flags

Comment 5 by smaier@chromium.org, Aug 18 2016

Status: Fixed (was: Untriaged)
Our ProGuard configs are pretty well optimized (save obfuscation), I don't forsee any work on optimizing them further.

Sign in to add a comment