New issue
Advanced search Search tips

Issue 620345 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Refactor vector drawing code between R_ARC_TO and ARC_TO

Project Member Reported by tdander...@chromium.org, Jun 15 2016

Issue description

The vector drawing code shared by the R_ARC_TO and ARC_TO commands should be refactored into a single helper function.

 
Cc: -est...@chromium.org
Owner: est...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56b7f3ae8d0c4e53cbb7f24377ddd94c55558323

commit 56b7f3ae8d0c4e53cbb7f24377ddd94c55558323
Author: estade <estade@chromium.org>
Date: Wed Jun 15 21:13:17 2016

Share more code in ARC_TO/R_ARC_TO

BUG= 620345 

Review-Url: https://codereview.chromium.org/2068893003
Cr-Commit-Position: refs/heads/master@{#400010}

[modify] https://crrev.com/56b7f3ae8d0c4e53cbb7f24377ddd94c55558323/ui/gfx/paint_vector_icon.cc

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2204bc3ed92d74ed6b18cc5bbc1cd5f33bbeefc

commit a2204bc3ed92d74ed6b18cc5bbc1cd5f33bbeefc
Author: tdanderson <tdanderson@chromium.org>
Date: Thu Jun 16 21:55:17 2016

Fix check for ARC_TO vs R_ARC_TO for vector assets

Vector assets using ARC_TO or R_ARC_TO are
not drawn properly due to an incorrect
command type check in paint_vector_icon.cc.
To fix this, cache the command type at
the top of the switch statement.

BUG= 620345 
TEST=manual

Review-Url: https://codereview.chromium.org/2075863002
Cr-Commit-Position: refs/heads/master@{#400272}

[modify] https://crrev.com/a2204bc3ed92d74ed6b18cc5bbc1cd5f33bbeefc/ui/gfx/paint_vector_icon.cc

Components: -Internals>Graphics Internals>GPU
Moving old issues out of Internal>Graphics to delete this obsolete component ( crbug.com/685425  for details)

Sign in to add a comment