New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 620326 link

Starred by 1 user
Status: Fixed
Owner:
█ robhogan@chromium.org
Use other robhogan account instead.
Closed: Dec 2016
Cc:
nyerramilli@chromium.org
█ brajkumar@chromium.org
dgro...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Div in table cell: height is too short by cell border width

Reported by randscul...@gmail.com, Jun 15 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0

Example URL:
https://jsfiddle.net/RandScullard/zxe8z9am/

Steps to reproduce the problem:
1. View the JSFiddle at https://jsfiddle.net/RandScullard/zxe8z9am/

What is the expected behavior?
The result pane should show a white box with a thick black border with the text "Hello" in it. No red should be visible.

What went wrong?
There is a red area 20 pixels tall at the bottom of the white box inside the border (see attached). This is the table cell background color showing through because Chrome is sizing the innermost div incorrectly: 20 pixels too short. Please note that this is equal to the sum of the table cell's top and bottom border widths (10 pixels each).

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes Chrome Version 51.0.2704.84 m

Does this work in other browsers? Yes 

Chrome version: 53.0.2768.0  Channel: canary
OS Version: 10.0
Flash Version: Shockwave Flash 21.0 r0

This occurs in our production web application, so we're hoping to see a fix before this bug gets into the Stable channel.
ChromeBug.png
3.0 KB View Download

Comment 1 by cbiesin...@chromium.org, Jun 15 2016

Components: -Blink Blink>Layout>Table

Comment 2 by brajkumar@chromium.org, Jun 16 2016

Cc: brajkumar@chromium.org
Labels: -Type-Bug M-53 hasbisect OS-Linux OS-Mac Type-Bug-Regression
Owner: robhogan@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce on Windows 7, Ubuntu 14.04 and Mac OS 10.11.4 using chrome canary M53-53.0.2768.0.

Bisect Information:
=====================
Good build: 53.0.2756.0  
Bad Build : 53.0.2758.0  

Change Log URL: https://chromium.googlesource.com/chromium/src/+log/783d36f567c7a36fa829b011b26510e336a3260c..d5c75af8c710870b5a5f4067f17d72b50a21cd2f

From the above change log suspecting below change

Review URL: https://codereview.chromium.org/2037783002

robhogan@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1afb8400a1d933cd50a16947899b0d88d2d30fb0

commit 1afb8400a1d933cd50a16947899b0d88d2d30fb0
Author: robhogan <robhogan@gmail.com>
Date: Wed Jun 29 07:30:29 2016

Use full available height when sizing percent content in cells

This was an error in https://codereview.chromium.org/2037783002. I shouldn't be
baking in the notion of content-box a second time to cells like that: the available height to
its content is already constrained by the content box.

I can't now see any good reason for why I did that - I think was erroneously trying
to match old, incorrect behaviour in some results.

BUG= 620326 

Review-Url: https://codereview.chromium.org/2075393002
Cr-Commit-Position: refs/heads/master@{#402748}

[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/fast/table/031-expected.png
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/fast/table/031-expected.txt
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/fast/table/colspan-with-all-percent-cells-expected.txt
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-align-center-expected.png
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-align-center-expected.txt
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-align-left-expected.png
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-align-left-expected.txt
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-align-right-expected.png
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-align-right-expected.txt
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-expected.png
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-expected.txt
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.png
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
[modify] https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0/third_party/WebKit/Source/core/layout/LayoutBox.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3de9e6ac0786925729bdd9678fe5bc6c92e6515

commit e3de9e6ac0786925729bdd9678fe5bc6c92e6515
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Jun 29 09:06:18 2016

Auto-rebaseline for r402748

https://chromium.googlesource.com/chromium/src/+/1afb8400a

BUG= 620326 
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/2108143002 .

Cr-Commit-Position: refs/heads/master@{#402759}

[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac-mac10.9/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/fast/html/details-writing-mode-align-center-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/fast/html/details-writing-mode-align-center-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/fast/html/details-writing-mode-align-left-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/fast/html/details-writing-mode-align-left-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/fast/html/details-writing-mode-align-right-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/fast/html/details-writing-mode-align-right-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/fast/html/details-writing-mode-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/fast/html/details-writing-mode-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/fast/html/details-writing-mode-align-center-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/fast/html/details-writing-mode-align-center-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/fast/html/details-writing-mode-align-left-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/fast/html/details-writing-mode-align-left-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/fast/html/details-writing-mode-align-right-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/fast/html/details-writing-mode-align-right-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/fast/html/details-writing-mode-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/fast/html/details-writing-mode-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/e3de9e6ac0786925729bdd9678fe5bc6c92e6515/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 5 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by nyerramilli@chromium.org, Jul 7 2016

Cc: nyerramilli@chromium.org
Labels: TE-Verified-53.0.2785.8 TE-Verified-M53
Tested the issue on Win7, Mac OS X & Ubuntu 14.04 using Dev # 53.0.2785.8 -  No red is visible.

attached screenshot for reference, adding TE-Verified labels.
620326.jpg
68.8 KB View Download

Comment 7 by robhogan@chromium.org, Dec 14 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment