Browsing data counters are currently used only on Desktop and Android, and thus they are defined in //chrome/browser/browsing_data. In order to be able to add them to iOS, we need to componentize them. This means: 1. Move counters to the component //components/browsing_data (ideally create a subdirectory counters/ there). https://cs.chromium.org/search/?q=file:chrome/browser/browsing_data/.*counter.(cc%7Ch) 2. Move their tests with them if possible (some tests might strongly depend on //chrome/browser). https://cs.chromium.org/search/?q=file:chrome/browser/browsing_data/.*counter.*test%5C.cc
(Starring instead of Cc.)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c776d1065425025fdcded9885505ea4637158929 commit c776d1065425025fdcded9885505ea4637158929 Author: ioanap <ioanap@google.com> Date: Wed Jul 06 11:09:39 2016 Moved BrowsingDataCounter and part of BrowsingDataCounterUtils to components. Changes: - BrowsingDataCounter now resides in components/browsing_data/counters/ - Moved enums and TimePeriod utils to components/browsing_data/browsing_data_utils[.h/.cc] - Changes to the counters that still reside in chrome/browser/browsing_data/ are temporary, meant to allow this partial change. They will be moved to components in a subsequent CL TBR=dbeam@chromium.org BUG=620317 Review-Url: https://codereview.chromium.org/2084903002 Cr-Commit-Position: refs/heads/master@{#403882} [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/android/BUILD.gn [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/android/browsing_data/browsing_data_counter_bridge.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/android/preferences/pref_service_bridge.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/autofill_counter.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/autofill_counter.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/autofill_counter_browsertest.cc [delete] https://crrev.com/fb5d97fe15cad0fe83a5cbca967efeb6fd63ba2c/chrome/browser/browsing_data/browsing_data_counter.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/browsing_data_counter_utils.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/browsing_data_counter_utils.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/browsing_data_remover.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/browsing_data_remover.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/browsing_data_remover_unittest.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/cache_counter.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/cache_counter.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/cache_counter_browsertest.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/downloads_counter.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/downloads_counter.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/downloads_counter_browsertest.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/history_counter.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/history_counter.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/history_counter_browsertest.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/hosted_apps_counter.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/hosted_apps_counter.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/hosted_apps_counter_unittest.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/media_licenses_counter.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/media_licenses_counter.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/media_licenses_counter_browsertest.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/passwords_counter.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/passwords_counter.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/passwords_counter_browsertest.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/browsing_data/site_data_size_collector.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/net/sdch_browsertest.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/ui/browser_ui_prefs.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/ui/webui/options/clear_browser_data_handler.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/ui/webui/options/clear_browser_data_handler.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/chrome.gyp [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/chrome_browser.gypi [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/common/pref_names.cc [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/chrome/common/pref_names.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/components/browsing_data.gypi [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/components/browsing_data/BUILD.gn [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/components/browsing_data/DEPS [add] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/components/browsing_data/browsing_data_utils.cc [add] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/components/browsing_data/browsing_data_utils.h [add] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/components/browsing_data/counters/browsing_data_counter.cc [rename] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/components/browsing_data/counters/browsing_data_counter.h [add] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/components/browsing_data/pref_names.cc [add] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/components/browsing_data/pref_names.h [modify] https://crrev.com/c776d1065425025fdcded9885505ea4637158929/tools/android/eclipse/.classpath
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6d9534492f46738b63b7d8500cd411bd723aa80 commit c6d9534492f46738b63b7d8500cd411bd723aa80 Author: ioanap <ioanap@google.com> Date: Mon Jul 11 13:41:15 2016 Add BrowsingDataCounterFactory Add a factory to facilitate the creation of browsing data counters for when they will be fully componentized. BUG=620317 Review-Url: https://codereview.chromium.org/2121203002 Cr-Commit-Position: refs/heads/master@{#404648} [modify] https://crrev.com/c6d9534492f46738b63b7d8500cd411bd723aa80/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc [add] https://crrev.com/c6d9534492f46738b63b7d8500cd411bd723aa80/chrome/browser/browsing_data/browsing_data_counter_factory.cc [add] https://crrev.com/c6d9534492f46738b63b7d8500cd411bd723aa80/chrome/browser/browsing_data/browsing_data_counter_factory.h [modify] https://crrev.com/c6d9534492f46738b63b7d8500cd411bd723aa80/chrome/browser/browsing_data/browsing_data_counter_utils.cc [modify] https://crrev.com/c6d9534492f46738b63b7d8500cd411bd723aa80/chrome/browser/browsing_data/browsing_data_counter_utils.h [modify] https://crrev.com/c6d9534492f46738b63b7d8500cd411bd723aa80/chrome/browser/ui/webui/options/clear_browser_data_handler.cc [modify] https://crrev.com/c6d9534492f46738b63b7d8500cd411bd723aa80/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc [modify] https://crrev.com/c6d9534492f46738b63b7d8500cd411bd723aa80/chrome/chrome_browser.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/918aa6d29219129f5c7eb32ea8e222b13b2a922a commit 918aa6d29219129f5c7eb32ea8e222b13b2a922a Author: ioanap <ioanap@google.com> Date: Wed Jul 13 11:31:13 2016 Move browsing data deletion prefs to components Move the pref_names related to browsing data deletion from chrome/common/ to components/browsing_data. They will be needed in the componentized counters. BUG=620317 Review-Url: https://codereview.chromium.org/2136373003 Cr-Commit-Position: refs/heads/master@{#405123} [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/autofill_counter.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/autofill_counter_browsertest.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/browsing_data_counter_factory.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/browsing_data_counter_utils.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/cache_counter.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/cache_counter_browsertest.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/downloads_counter.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/downloads_counter_browsertest.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/history_counter.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/history_counter_browsertest.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/hosted_apps_counter.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/hosted_apps_counter_unittest.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/media_licenses_counter.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/media_licenses_counter_browsertest.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/passwords_counter.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/browsing_data/passwords_counter_browsertest.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/ui/browser_ui_prefs.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/common/pref_names.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/chrome/common/pref_names.h [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/components/browsing_data/pref_names.cc [modify] https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a/components/browsing_data/pref_names.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b94192650ba11fee85a268cd2874df06f0ee8e7f commit b94192650ba11fee85a268cd2874df06f0ee8e7f Author: ioanap <ioanap@google.com> Date: Wed Jul 20 08:24:47 2016 Make browsing_data component a layered component The browsing_data component will have the following structure - core/ - counters/ - counters files - util files - content/ - conditional_cache_deletion_helper.* - storage_partition_http_cache_data_remover.* BUG=620317 Review-Url: https://codereview.chromium.org/2127403002 Cr-Commit-Position: refs/heads/master@{#406517} [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/android/BUILD.gn [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/BUILD.gn [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/android/browsing_data/browsing_data_counter_bridge.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/android/preferences/pref_service_bridge.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/autofill_counter.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/autofill_counter.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/autofill_counter_browsertest.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/browsing_data_counter_factory.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/browsing_data_counter_utils.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/browsing_data_counter_utils.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/browsing_data_remover.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/browsing_data_remover.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/browsing_data_remover_unittest.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/cache_counter.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/cache_counter.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/cache_counter_browsertest.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/downloads_counter.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/downloads_counter.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/downloads_counter_browsertest.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/history_counter.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/history_counter.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/history_counter_browsertest.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/hosted_apps_counter.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/hosted_apps_counter.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/hosted_apps_counter_unittest.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/media_licenses_counter.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/media_licenses_counter.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/media_licenses_counter_browsertest.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/passwords_counter.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/passwords_counter.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/browsing_data/passwords_counter_browsertest.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/ui/browser_ui_prefs.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/ui/webui/options/clear_browser_data_handler.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/ui/webui/options/clear_browser_data_handler.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/chrome/chrome_browser.gypi [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data.gypi [delete] https://crrev.com/bb921dfc13aad262dfff7270a8949b6032c6fb23/components/browsing_data/BUILD.gn [add] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/content/BUILD.gn [rename] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/content/DEPS [rename] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/content/conditional_cache_deletion_helper.cc [rename] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/content/conditional_cache_deletion_helper.h [rename] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/content/storage_partition_http_cache_data_remover.cc [rename] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/content/storage_partition_http_cache_data_remover.h [add] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/core/BUILD.gn [add] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/core/DEPS [rename] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/core/browsing_data_utils.cc [rename] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/core/browsing_data_utils.h [rename] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/core/counters/browsing_data_counter.cc [rename] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/core/counters/browsing_data_counter.h [rename] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/core/pref_names.cc [rename] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/browsing_data/core/pref_names.h [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/components/components.gyp [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/extensions/browser/BUILD.gn [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/extensions/browser/guest_view/web_view/web_view_guest.cc [modify] https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f/extensions/extensions.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4245d2bac2ab4d5092e83bbb3ac34174654646e2 commit 4245d2bac2ab4d5092e83bbb3ac34174654646e2 Author: ioanap <ioanap@google.com> Date: Mon Jul 25 13:28:11 2016 Move counters for passwords, history and autofill to components Files moved from c/b/browsing_data/ to components/browsing_data/core/counters: - autofill_counter.* - passwords_counter.* - history_counter.* BUG=620317 Review-Url: https://codereview.chromium.org/2153863002 Cr-Commit-Position: refs/heads/master@{#407462} [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/autofill_counter_browsertest.cc [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/browsing_data_counter_factory.cc [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/browsing_data_counter_utils.cc [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/cache_counter.cc [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/cache_counter.h [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/downloads_counter.cc [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/downloads_counter.h [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/history_counter_browsertest.cc [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/hosted_apps_counter.cc [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/hosted_apps_counter.h [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/media_licenses_counter.cc [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/media_licenses_counter.h [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/browser/browsing_data/passwords_counter_browsertest.cc [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/chrome/chrome_browser.gypi [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/components/browsing_data.gypi [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/components/browsing_data/core/BUILD.gn [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/components/browsing_data/core/DEPS [rename] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/components/browsing_data/core/counters/autofill_counter.cc [rename] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/components/browsing_data/core/counters/autofill_counter.h [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/components/browsing_data/core/counters/browsing_data_counter.cc [modify] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/components/browsing_data/core/counters/browsing_data_counter.h [rename] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/components/browsing_data/core/counters/history_counter.cc [rename] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/components/browsing_data/core/counters/history_counter.h [rename] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/components/browsing_data/core/counters/passwords_counter.cc [rename] https://crrev.com/4245d2bac2ab4d5092e83bbb3ac34174654646e2/components/browsing_data/core/counters/passwords_counter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/556a0adf05225bd20e66cff7a7553838c4170b40 commit 556a0adf05225bd20e66cff7a7553838c4170b40 Author: ioanap <ioanap@google.com> Date: Tue Aug 16 13:39:54 2016 Move part of browsing data counter text util method to components Extract part of the method that constructs the text for browsing data counters into the utils in components/browsing_data/core/. This will return the text for the counters that have been moved to components: PasswordsCounter, AutofillCounter and HistoryCounter. TBRing for trivial method rename in: c/b/android/browsing_data/browsing_data_counter_bridge.cc c/b/ui/webui/settings/settings_clear_browsing_data_handler.cc c/b/ui/webui/options/clear_browser_data_handler.cc TBR=bauerb@chromium.org, dbeam@chromium.org BUG=620317 Review-Url: https://codereview.chromium.org/2228913003 Cr-Commit-Position: refs/heads/master@{#412227} [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/chrome/app/generated_resources.grd [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/chrome/browser/browsing_data/browsing_data_counter_utils.cc [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/chrome/browser/browsing_data/browsing_data_counter_utils.h [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/chrome/browser/ui/webui/options/clear_browser_data_handler.cc [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/components/BUILD.gn [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/components/OWNERS [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/components/browsing_data/core/BUILD.gn [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/components/browsing_data/core/DEPS [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/components/browsing_data/core/browsing_data_utils.cc [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/components/browsing_data/core/browsing_data_utils.h [add] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/components/browsing_data/core/browsing_data_utils_unittest.cc [add] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/components/browsing_data_strings.grdp [modify] https://crrev.com/556a0adf05225bd20e66cff7a7553838c4170b40/components/components_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0f8c87175e36849b71e14ed6aeaa597ffa4ad69 commit f0f8c87175e36849b71e14ed6aeaa597ffa4ad69 Author: ioanap <ioanap@google.com> Date: Wed Aug 17 11:26:45 2016 Move method that matches the data type with the deletion preference for browsing data to components TBRing for trivial rename in: c/b/android/browsing_data/browsing_data_counter_bridge.cc c/b/android/preferences/pref_service_bridge.cc TBR=bauerb@chromium.org BUG=620317 Review-Url: https://codereview.chromium.org/2230243002 Cr-Commit-Position: refs/heads/master@{#412497} [modify] https://crrev.com/f0f8c87175e36849b71e14ed6aeaa597ffa4ad69/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc [modify] https://crrev.com/f0f8c87175e36849b71e14ed6aeaa597ffa4ad69/chrome/browser/android/preferences/pref_service_bridge.cc [modify] https://crrev.com/f0f8c87175e36849b71e14ed6aeaa597ffa4ad69/chrome/browser/browsing_data/browsing_data_counter_utils.cc [modify] https://crrev.com/f0f8c87175e36849b71e14ed6aeaa597ffa4ad69/chrome/browser/browsing_data/browsing_data_counter_utils.h [modify] https://crrev.com/f0f8c87175e36849b71e14ed6aeaa597ffa4ad69/components/browsing_data/core/browsing_data_utils.cc [modify] https://crrev.com/f0f8c87175e36849b71e14ed6aeaa597ffa4ad69/components/browsing_data/core/browsing_data_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d290dc4a1bcac7ad6cd67553e5831fa3680d6bb commit 2d290dc4a1bcac7ad6cd67553e5831fa3680d6bb Author: msramek <msramek@chromium.org> Date: Fri Sep 23 11:36:24 2016 Add a cache counter for iOS. The CacheCounter class in chrome/browser/browsing_data could not be componentized (unlike other counters in components/browsing_data) because of its usage of StoragePartitionHttpCacheDataRemover that has a dependency on content/. This CL implements a separate CacheCounter class for iOS with the same functionality. The core of the implementation, a series of IO thread callbacks, is delegated to the private IOThreadCacheCounter class that mimics StoragePartitionHttpCacheDataRemover. BUG=620317 Review-Url: https://codereview.chromium.org/2354643002 Cr-Commit-Position: refs/heads/master@{#420599} [modify] https://crrev.com/2d290dc4a1bcac7ad6cd67553e5831fa3680d6bb/ios/chrome/BUILD.gn [modify] https://crrev.com/2d290dc4a1bcac7ad6cd67553e5831fa3680d6bb/ios/chrome/browser/BUILD.gn [add] https://crrev.com/2d290dc4a1bcac7ad6cd67553e5831fa3680d6bb/ios/chrome/browser/browsing_data/cache_counter.cc [add] https://crrev.com/2d290dc4a1bcac7ad6cd67553e5831fa3680d6bb/ios/chrome/browser/browsing_data/cache_counter.h [add] https://crrev.com/2d290dc4a1bcac7ad6cd67553e5831fa3680d6bb/ios/chrome/browser/browsing_data/cache_counter_unittest.cc [modify] https://crrev.com/2d290dc4a1bcac7ad6cd67553e5831fa3680d6bb/ios/chrome/browser/browsing_data/ios_browsing_data_counter_factory.cc
Previous owner is no longer at Google? Making available.
Comment 1 by msramek@chromium.org
, Jun 15 2016