New issue
Advanced search Search tips

Issue 620270 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: May 2018
Cc:
qyears...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocked on:
issue 672651


Sign in to add a comment

run-webkit-tests requires Ruby, which is not installed automatically (via depot_tools etc)

Project Member Reported by cbiesin...@chromium.org, Jun 15 2016 
I tried run-webkit-tests on my Windows laptop. I got:
Ruby is not installed; can't generate pretty patches.

Why do we need Ruby? And if we do need Ruby, shouldn't we ship it in depot_tools for Windows, or download it in runhooks>

Comment 1 by qyears...@chromium.org, Jun 17 2016

Cc: qyears...@chromium.org
The only thing that's in ruby is this: https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/

Which I believe is used for "pretty diffs" when showing results.

Do the tests still run on Windows when ruby is not available?

Comment 2 by cbiesin...@chromium.org, Jun 18 2016 

Yes, but I want the pretty diffs!

The tests do run without it.

Comment 3 by qyears...@chromium.org, Jun 27 2016

Summary: run-webkit-tests requires Ruby, which is not installed automatically (via depot_tools etc) (was: Why does run-webkit-tests want Ruby installed?)

Comment 4 by qyears...@chromium.org, Dec 22 2016

Blockedon: 672651
Status: Available (was: Unconfirmed)
This will be obsolete once we remove PrettyPatch.rb and replace it with a Python module.

Comment 5 by qyears...@chromium.org, Jun 23 2017 

Still blocked on  bug 672651 .

Comment 6 by tkent@chromium.org, May 9 2018

Status: Fixed (was: Available)
►

Sign in to add a comment