MacViews: Findbar window hiding on restore.
Reported by
k...@yandex-team.ru,
Jun 15 2016
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 YaBrowser/16.6.0.8326 (beta) Safari/537.36 Steps to reproduce the problem: It reproduces only in MacViewsBrowser. 1. Open findbar. 2. Minimize browser window using "minimize" window button. 3. Restore browser window by clicking on application icon. What is the expected behavior? Findbar is visible. What went wrong? Findbar is not visible and could not be showed without hiding window again. Video: https://drive.google.com/open?id=0ByXTnneU3LLDWkNVd05XbmNqdHM I've investigated it a little. Seems that there is a cocoa bug that is appears because of complicated window minimization logic in mac views. Small example of this is attached. Did this work before? N/A Chrome version: 50.0.2661.102 Channel: n/a OS Version: OS X 10.11.3 Flash Version: Shockwave Flash 22.0 r0
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a3314d270102d9a6dc6572846f406290021d776 commit 7a3314d270102d9a6dc6572846f406290021d776 Author: kirr <kirr@yandex-team.ru> Date: Thu Jun 30 13:50:55 2016 MacViews: Ensure child windows are only managed with real changes to -[NSWindow isVisible]. After restoring from a miniaturize, child windows are currently reattached too early. This is because AppKit draws the window before updating the result of -[NSWindow isVisible], and we need to participate in that draw. But updating child window relationships at this time causes layering issues when the window has finished restoring. BUG= 620266 Review-Url: https://codereview.chromium.org/2069103004 Cr-Commit-Position: refs/heads/master@{#403166} [modify] https://crrev.com/7a3314d270102d9a6dc6572846f406290021d776/ui/views/cocoa/bridged_native_widget.h [modify] https://crrev.com/7a3314d270102d9a6dc6572846f406290021d776/ui/views/cocoa/bridged_native_widget.mm [modify] https://crrev.com/7a3314d270102d9a6dc6572846f406290021d776/ui/views/cocoa/native_widget_mac_nswindow.mm [modify] https://crrev.com/7a3314d270102d9a6dc6572846f406290021d776/ui/views/cocoa/views_nswindow_delegate.h [modify] https://crrev.com/7a3314d270102d9a6dc6572846f406290021d776/ui/views/cocoa/views_nswindow_delegate.mm [modify] https://crrev.com/7a3314d270102d9a6dc6572846f406290021d776/ui/views/widget/native_widget_mac_unittest.mm
,
Jul 7 2016
Rechecked this on Chrome version 53.0.2785.8 on MAC 10.11.5, fix is working as Intended. Find In window stays even minimising the browser and restoring it. Adding TE-Verified labels.
,
Aug 12 2016
Fixed and verified by TE, then. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tapted@chromium.org
, Jun 15 2016Status: Available (was: Unconfirmed)