Issue metadata
Sign in to add a comment
|
Regression: All history records are not visible after closing search field.
Reported by
rk...@etouch.net,
Jun 15 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 53.0.2768.0 Revision 9cd2e77b728d6d5ac115acd944b37df70423c355-refs/heads/master@{#399800} OS: Windows(7,8,10),Mac(10.10.5,10.11.4) Pr-condition: 1. Enable Material Design history flag from chrome://flags. 2. Create some history by navigating any webpage. What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://history (2) Click on iron icon of any link and then select 'More from this site' option(Related search site will seen). (3) Click on close icon of search field and observe. After closing search field, all history records are not visible i.e previous result is seen. After closing search field, all history records should be visible. This is a regression issue, broken in 'M-53', below is bisect info: Good Build: 53.0.2767.0 Bad Build: 53.0.2768.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/de0b6c94961b7234c1c2da0f0c7fa09ff2672bfa..dca42159c2b19c25f033ff6e5e0da8d70a491576?pretty=fuller&n=50 Suspecting: r399750 Note: will soon update the Linux OS info.
,
Jun 15 2016
FYI I have a candidate fix for this, will send out once I verify everything works and add some tests.
,
Jun 15 2016
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a48717579ccbf96d3adc62f0c831d226761ddf1 commit 0a48717579ccbf96d3adc62f0c831d226761ddf1 Author: dpapad <dpapad@chromium.org> Date: Thu Jun 16 01:40:42 2016 WebUI cr-search-field: Trigger event after programmatically clearing query. This fixes a regression in MD History where the results were not updated after the user clicks the 'x' button. BUG= 620250 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2075453002 Cr-Commit-Position: refs/heads/master@{#400072} [modify] https://crrev.com/0a48717579ccbf96d3adc62f0c831d226761ddf1/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js [modify] https://crrev.com/0a48717579ccbf96d3adc62f0c831d226761ddf1/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js
,
Jun 16 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dpa...@chromium.org
, Jun 15 2016