New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620241 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Hide or remove EnableMaximizeModeWindowManager() in maximize_mode_controller

Project Member Reported by jcliang@chromium.org, Jun 15 2016

Issue description

After we replace lid_open_past_180_ with IsMaximizeModeWindowManagerEnabled() in https://codereview.chromium.org/2020553003/ we should further hide EnableMaximizeModeWindowManager() and force all state change through {Enter|Exit}MaximizeMode() instead. Comments from @flackr:

"""
Unfortunately IsMaximizeModeWindowManagerEnabled is not synonymous with
lid_open_past_180_. If we want to make this change we should remove
EnableMaximizeModeWindowManager and force all state changes through
(Enter|Exit)MaximizeMode instead. I do think this is a worthwhile cleanup -
having the separate state for testing code is really messy. We can even remove
the keyboard shortcut for touchview testing.

What will happen is with this change, when you enable the touchview testing flag
and use the keyboard shortcut to enable touchview
(https://cs.chromium.org/chromium/src/ash/accelerators/accelerator_controller....)
we won't disable the keyboard and touchpad when the lid is opened past 180
degrees.
"""
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 15 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by loyso@chromium.org, May 30 2018

Ping? Any progress?

Comment 3 by loyso@chromium.org, May 30 2018

Components: Internals>Services>Ash UI>Shell>TouchView
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment