New issue
Advanced search Search tips

Issue 620236 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 625836



Sign in to add a comment

Crash when using touch events with gpu benchmarking

Project Member Reported by nzolghadr@chromium.org, Jun 15 2016

Issue description

This crash happens in some of the pointer events that are using gpu benchmarking while sending touch actions:

[48422:48422:0615/042040:732378223419:FATAL:synthetic_gesture_target_base.cc(62)] Check failed: web_touch.touches[i].state != WebTouchPoint::StatePressed || PointIsWithinContents(web_touch.touches[i].position.x, web_touch.touches[i].position.y). Touch coordinates are not within content bounds on TouchStart.
#0 0x00000047614e base::debug::StackTrace::StackTrace()
#1 0x00000047ff7b logging::LogMessage::~LogMessage()
#2 0x00000235e9b9 content::SyntheticGestureTargetBase::DispatchInputEventToPlatform()
#3 0x00000235fcce content::SyntheticSmoothMoveGesture::ForwardTouchInputEvents()
#4 0x00000235f945 content::SyntheticSmoothMoveGesture::ForwardInputEvents()
#5 0x00000235dcb0 content::SyntheticGestureController::Flush()
#6 0x0000004d0bc5 base::Timer::RunScheduledTask()
#7 0x0000004c5836 base::debug::TaskAnnotator::RunTask()
#8 0x000000482935 base::MessageLoop::RunTask()
#9 0x000000482c28 base::MessageLoop::DeferOrRunPendingTask()
#10 0x00000048316c base::MessageLoop::DoDelayedWork()
#11 0x0000004c3d90 base::(anonymous namespace)::WorkSourceDispatch()
#12 0x7f0b0846ae04 g_main_context_dispatch
#13 0x7f0b0846b048 <unknown>
#14 0x7f0b0846b0ec g_main_context_iteration
#15 0x0000004c3c46 base::MessagePumpGlib::Run()
#16 0x0000004941ee base::RunLoop::Run()
#17 0x000002278899 content::BrowserMainLoop::MainMessageLoopRun()
#18 0x0000022786e5 content::BrowserMainLoop::RunMainMessageLoopParts()
#19 0x0000020c24ad content::BrowserMainRunnerImpl::Run()
#20 0x000000420498 LayoutTestBrowserMain()
#21 0x00000041ff23 content::ShellMainDelegate::RunProcess()
#22 0x000000462dd2 content::RunNamedProcessTypeMain()
#23 0x000000463737 content::ContentMainRunnerImpl::Run()
#24 0x000000462250 content::ContentMain()
#25 0x00000041edbb main
#26 0x7f0b03f95f45 __libc_start_main
#27 0x00000041ecb9 <unknown>

 
Owner: lanwei@chromium.org

Comment 2 by lanwei@chromium.org, Jun 28 2016

I could not reproduce on my machine. Can you please tell me more about how you got this error? Thanks.
Do you run the test in the review?
https://codereview.chromium.org/2056333002/

For example this test:
imported/wpt/pointerevents/pointerevent_touch-action-bitton-test_touch-manual.html

You can wait a few days until that change goes in to make it easier to test if you like.
Blocking: 625836
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6d61f2a2afb8560ea805450887d802cb90bf117

commit c6d61f2a2afb8560ea805450887d802cb90bf117
Author: lanwei <lanwei@chromium.org>
Date: Thu Jul 14 20:41:22 2016

Make the crashed web platform pointerevent tests pass.

In the Issue 2130433002, Navid had to skip some pointerevent tests because they crashed for some reasons.
This patch fixes it and also remove them from the TestExpectations file.

BUG= 620236 

Review-Url: https://codereview.chromium.org/2127303002
Cr-Commit-Position: refs/heads/master@{#405558}

[modify] https://crrev.com/c6d61f2a2afb8560ea805450887d802cb90bf117/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/c6d61f2a2afb8560ea805450887d802cb90bf117/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c6d61f2a2afb8560ea805450887d802cb90bf117/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js

Status: Fixed (was: Assigned)

Sign in to add a comment