New issue
Advanced search Search tips

Issue 620228 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.1% regression in speedometer at 399781:399795

Project Member Reported by nikolaos@chromium.org, Jun 15 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=620228

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_NHhtgkM


Bot(s) for this bug's original alert(s):

chromium-rel-mac10
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jun 15 2016

Cc: f...@opera.com
Owner: f...@opera.com

=== Auto-CCing suspected CL author fs@opera.com ===

Hi fs@opera.com, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Remove redundant "layout size changed" state from LayoutSVGRoot
Author  : fs
Commit description:
  
In LayoutSVGRoot::layout, two slightly different "layout size changed"
values are computed - one which is used for propagation to children
via SVGLayoutSupport::layoutSizeOfNearestViewportChanged
(|m_isLayoutSizeChanged|), and one which is used to mark direct
descendant children (local |layoutSizeChanged|).
Ultimately their use is the same though, so only using the more narrow
predicate for both of these cases should yield the same result.
It also has the side-effect of making it more obvious that changes to
layout-size is only of interest when there exist clients of the SVG
root that have relative lengths.

BUG= 603956 

Review-Url: https://codereview.chromium.org/2065093002
Cr-Commit-Position: refs/heads/master@{#399791}
Commit  : 30770a70834c73670884f0de91bb7624df0ba003
Date    : Tue Jun 14 21:49:52 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@399780  1076.28  11.2769  5   good
chromium@399788  1093.5   14.5042  18  good
chromium@399790  1092.37  11.8243  18  good
chromium@399791  1103.06  11.9336  18  bad    <--
chromium@399792  1110.21  21.8546  18  bad
chromium@399795  1102.86  12.0184  8   bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 620228

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: EmberJS-TodoMVC/EmberJS-TodoMVC
Relative Change: 2.98%
Score: 99.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2147
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009805918267824352


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5850257624137728

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 3 by f...@opera.com, Jun 17 2016

Labels: -performance-sheriff Performance-Sheriff
I'll revert the suspected CL, then we'll see what happens. (https://codereview.chromium.org/2071953004/)

Comment 4 by f...@opera.com, Jun 17 2016

Revert landed in r400411, but did not have any effect, suggesting something else is the culprit.

Comment 5 by f...@opera.com, Jun 17 2016

Owner: ----
Not sure if a narrower bisect could help (considering the increase in N around the indicated revision.)

Comment 6 by f...@opera.com, Jun 23 2016

Owner: kojii@chromium.org
Just to randomly kick the ball further... Maybe r399789 (not corroborated by data.)

Comment 7 by kojii@chromium.org, Jun 23 2016

Cc: kojii@chromium.org
Owner: hablich@chromium.org
My CL tests runtime flag and do nothing unless CustomElementsV1 is enabled. I don't think testing runtime flag can regress...

hablich@, could this possibly related with v8?
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 5 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Kicked of a wider bisect, let's see if it reproduces. If not, I will close this bug because it is strange that only one bot is affected.

===== BISECT JOB RESULTS =====
Status: completed


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N   Good?
chromium@399700                1073.54  8.4681   12  good
chromium@399775                1075.99  9.58037  12  good
chromium@399785                1072.22  13.8493  8   good
chromium@399786                1072.62  8.40268  8   good
chromium@399786,v8@6c5152406f  1077.64  16.6125  8   good
chromium@399786,v8@f1ac74b253  1076.84  6.91954  8   good
chromium@399786,v8@7446a74f94  1072.76  14.9964  8   good
chromium@399786,v8@a5719850bf  1071.82  8.42719  5   good
chromium@399787                1104.15  17.6629  8   bad
chromium@399788                1109.7   31.0402  8   bad
chromium@399790                1100.92  11.0028  5   bad
chromium@399794                1096.89  12.2299  8   bad
chromium@399813                1117.55  39.0269  5   bad
chromium@399850                1095.48  22.7331  8   bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 620228

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: EmberJS-TodoMVC/EmberJS-TodoMVC
Relative Change: 2.12%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2184
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007806310717637824


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5230196328759296

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: WontFix (was: Assigned)
ok, that CL cannot be the culprit because it is a revert and was never rolled in before ...
Status: Assigned (was: WontFix)
Please retrigger relevant bisection jobs because http://crbug.com/628214 got fixed.
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Jul 15 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [ic] Temporary resurrect ICStateField to recover performance regression.
Author  : ishell
Commit description:
  
Zero value of ICStateField part made megamorphic stub cache unusable.
We need to revisit hashing algorithm in order to remove the ICStateField.

BUG=chromium:619016
LOG=N

Review-Url: https://codereview.chromium.org/2064713002
Cr-Commit-Position: refs/heads/master@{#36959}
Commit  : 6c5152406f29676b50eb9db10b82b7dfb92ac5d6
Date    : Tue Jun 14 10:54:33 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N   Good?
chromium@399780                1076.46  28.4748  12  good
chromium@399784                1066.94  16.5968  5   good
chromium@399786                1071.75  9.8237   8   good
chromium@399786,v8@759baaff78  1068.43  9.30704  8   good
chromium@399786,v8@c1b2499027  1076.09  5.51592  8   good
chromium@399786,v8@bd451d421b  1070.21  3.78108  5   good
chromium@399786,v8@6c5152406f  1102.48  33.4197  5   bad    <--
chromium@399787                1098.89  10.7771  5   bad
chromium@399788                1112.93  27.3633  5   bad
chromium@399795                1093.83  13.597   12  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 620228

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: EmberJS-TodoMVC/EmberJS-TodoMVC
Relative Change: 0.54%
Score: 80.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2206
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007088634760702640


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5860416459112448

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 16 by 42576172...@developer.gserviceaccount.com, Jul 15 2016

Cc: ishell@chromium.org
Owner: ishell@chromium.org

=== Auto-CCing suspected CL author ishell@chromium.org ===

Hi ishell@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [ic] Split LoadIC into LoadGlobalIC and LoadIC.
Author  : ishell
Commit description:
  
The former will handle loads of predeclared global variables (vars and
functions), lets, consts and undeclared variables. The latter will handle
named loads from explicit receiver. In addition, named loads does not
depend of the TypeofMode.

TypeofMode related cleanup will be done in the follow-up CL.

BUG=chromium:576312
LOG=Y
TBR=bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/1912633002
Cr-Commit-Position: refs/heads/master@{#36965}
Commit  : d9e8764f8132a6d5b84acfc54b27fde0cb65d963
Date    : Tue Jun 14 13:21:28 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N   Good?
chromium@399700                1080.74  9.62518  12  good
chromium@399775                1055.16  7.22459  5   good
chromium@399785                1062.34  12.1743  8   good
chromium@399786                1075.78  20.65    12  good
chromium@399786,v8@6c5152406f  1074.75  11.7886  18  good
chromium@399786,v8@fc59eb8a7a  1077.68  21.3858  18  good
chromium@399786,v8@098964544a  1081.44  14.3517  18  good
chromium@399786,v8@d9e8764f81  1099.76  15.6762  12  bad    <--
chromium@399786,v8@f1ac74b253  1096.92  15.2879  18  bad
chromium@399787                1103.67  26.627   12  bad
chromium@399788                1107.95  14.2968  5   bad
chromium@399790                1093.59  8.81001  8   bad
chromium@399794                1107.68  8.89665  5   bad
chromium@399813                1098.3   13.5698  5   bad
chromium@399850                1093.75  12.6405  12  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 620228

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: EmberJS-TodoMVC/EmberJS-TodoMVC
Relative Change: 0.54%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2207
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007085690701635520


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5860203455578112

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: Fixed (was: Assigned)
The mentioned regression since then was already improved, recovered, improved, regressed and will be recovered soon again. So, closing.

Sign in to add a comment