Issue metadata
Sign in to add a comment
|
Regression: Space issue is observed between bookmarked icon and its name.
Reported by
dmascare...@etouch.net,
Jun 15 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:52.0.2743.41 (Official Build)23b35b216a461bc1e5083485742c3bc9290b8943-refs/branch-heads/2743@{#361} 64 bit OS: Mac Pro (10.10.5,10.11.4),Mac Retina(10.11.4) Test urls: 1. https://matthewlein.com/ceaser/ 2. https://permission.site/ 3. chrome://bookmarks/ 4. https://support.google.com/chrome/answer/95464?p=incognito&rd=1#incognito 5. Also bookmark ‘New Tab’ What steps will reproduce the problem? 1. Launch chrome and bookmark all test urls. 2. Observe the bookmark bar. Actual: Space issue is observed between bookmarked icon and its name (i.e Space between them is decreased except ‘New Tab’ and Test url 4) Expected: Space between bookmarked icon and its name should be proper for every test url. This is regression issue,broken in ‘M 52’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/d195033a24b74413492685d93766932b64ad571e..27ceeaa6e172119ef8c1c7e21f0c61ea824d5e83?pretty=fuller&n=100 Suspecting: r394165 ? Good build:52.0.2739.0 Bad build:52.0.2740.0 Note: Above issue is not reproducible on Windows and Linux OS.
,
Jun 15 2016
Spacing seems to be correct, with 4pt of spacing between icon and text applied consistently to all bookmark items (see attached image, taken on a Retina machine). I think part of the issue is how the Appkit draws an "A" vs. an "N" - in the former case the lower-left end of the "A" creeps close to the icon vs. the "N" which doesn't start right at the edge of the start of the text area.
,
Jul 5 2016
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 3 2016
Above issue is still reproducible on Latest Canary Version:55.0.2878.0 (Official Build) 6bf82374fb3a17659851bc4e830c063577ba80fd-refs/heads/master@{#422326} on MAC PRO (10.10.5) (10.11.4)
,
Jun 26 2017
-> lgrey@ to see if this is still an issue.
,
Jun 26 2017
AFAICT this is fixed. Perceptually, this depends on icon size/shape and, as shrike@ mentioned, the first glyph in the title. Manually comparing via xScope shows a consistent 4x non-retina/8px retina between the icon bounding box and the first drawn pixel (usually subpixel AA shading) of the title. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Jun 15 2016