Autotest requires root access to test stations. |
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 7978.76.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.104 Safari/537.36 Platform: autotest Steps to reproduce the problem: 1. Create an Android host using atest. 2. Review the logs from host creation or test execution. What is the expected behavior? Atest should accept an alternate username for SSH. What went wrong? The default username cannot be overwritten. All commands are executed as root. Did this work before? No Chrome version: 50.0.2661.104 Channel: n/a OS Version: 7978.76.0 Flash Version: Shockwave Flash 21.0 r0
,
Jun 15 2016
,
Jun 15 2016
,
Jul 12 2016
,
Jul 15 2016
,
Jul 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5208eaac79f67826fb546d3c3516d6b04e467e3e commit 5208eaac79f67826fb546d3c3516d6b04e467e3e Author: Justin Giorgi <jgiorgi@google.com> Date: Sun Jul 03 03:12:12 2016 [autotest] Added per-host ssh parameters. Parameters are stored as host attributes ssh_user, ssh_port, ssh_verbosity_flag and ssh_options. Password is intentionally not stored. The verbosity flag and options are only used by CrosHost. No modifications necessary to ssh host objects because they already receive and utilize the parameters. Only modified factory to pull arguments from attributes before using existing defaults. Testbed and ADBHost were modified to pass the arguments through. Also fixed typo in factory and added tests. Modified atest host create to pass simulated afe_host so that detection of parameters by host attributes works even before the attributes are in afe. BUG= chromium:620196 TEST=Unit tests of changes to factory, confirmed manually locally and on moblab. Change-Id: I61ff857edf28b973d8241a275456219782f2ff03 Reviewed-on: https://chromium-review.googlesource.com/353040 Commit-Ready: Justin Giorgi <jgiorgi@google.com> Tested-by: Justin Giorgi <jgiorgi@google.com> Reviewed-by: Justin Giorgi <jgiorgi@google.com> [modify] https://crrev.com/5208eaac79f67826fb546d3c3516d6b04e467e3e/server/hosts/testbed.py [modify] https://crrev.com/5208eaac79f67826fb546d3c3516d6b04e467e3e/server/hosts/factory.py [modify] https://crrev.com/5208eaac79f67826fb546d3c3516d6b04e467e3e/server/hosts/base_label_unittest.py [modify] https://crrev.com/5208eaac79f67826fb546d3c3516d6b04e467e3e/cli/host.py [add] https://crrev.com/5208eaac79f67826fb546d3c3516d6b04e467e3e/server/hosts/factory_unittest.py [modify] https://crrev.com/5208eaac79f67826fb546d3c3516d6b04e467e3e/cli/host_unittest.py [modify] https://crrev.com/5208eaac79f67826fb546d3c3516d6b04e467e3e/server/hosts/adb_host.py
,
Jul 25 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jgiorgi@google.com
, Jun 15 2016