New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 620184 link

Starred by 1 user
Status: Fixed
Owner:
█ hirono@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
dewittj@chromium.org
█ yoshiki@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature



Sign in to add a comment

Refactoring is needed for message_center_settings_controller.{cc,h}

Project Member Reported by hirono@chromium.org, Jun 15 2016 
Version: ToT
OS: Chrome OS

Currently there is a lot of #if defined(CHROMEOS) code in message_center_settings_controller.{cc,h}. We should remove the conditional macros.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d36c21d3e9698566fac911dde6473d1023009caa

commit d36c21d3e9698566fac911dde6473d1023009caa
Author: hirono <hirono@chromium.org>
Date: Tue Jun 21 01:25:22 2016

Refactor MessageCenterSettingsController.

The CL does refactoring for MessageCenterSettingsController to get rid
of #ifdef macros for CHROME_OS.

1. Define NotifierSource abstract class that provides a list of specific
   type of notifiers.
2. Define subclass for each notifier type (APPLICATION, WEB_PAGE,
   SYSTEM_COMPONENT, ARC_APPLICATION).
3. Let MessageCenterSettingsController delegate to each source.

BUG= 620184 
TEST=None

Review-Url: https://codereview.chromium.org/2064363002
Cr-Commit-Position: refs/heads/master@{#400867}

[add] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/browser/notifications/application_notifier_source.cc
[add] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/browser/notifications/application_notifier_source.h
[add] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
[add] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/browser/notifications/arc_application_notifier_source_chromeos.h
[delete] https://crrev.com/4f1a60afd536b69df3b50077dd8ac8cfd67c0403/chrome/browser/notifications/arc_notifier_manager.cc
[modify] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/browser/notifications/message_center_settings_controller.cc
[modify] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/browser/notifications/message_center_settings_controller.h
[add] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/browser/notifications/notifier_source.h
[add] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/browser/notifications/system_component_notifier_source_chromeos.cc
[add] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/browser/notifications/system_component_notifier_source_chromeos.h
[add] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/browser/notifications/web_page_notifier_source.cc
[add] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/browser/notifications/web_page_notifier_source.h
[modify] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/chrome_browser.gypi
[modify] https://crrev.com/d36c21d3e9698566fac911dde6473d1023009caa/chrome/chrome_browser_ui.gypi

Comment 2 by hirono@chromium.org, Jun 21 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/075137c81c8ff72ba1abdffc13e15037fb4d1ffa

commit 075137c81c8ff72ba1abdffc13e15037fb4d1ffa
Author: hirono <hirono@chromium.org>
Date: Tue Jun 28 03:42:20 2016

Remove unused arc_notifier_manager.h.

The file unintentionally reamined when did refactoring for
MessageCenterSettingsController.

BUG= 620184 

Review-Url: https://codereview.chromium.org/2095273002
Cr-Commit-Position: refs/heads/master@{#402393}

[delete] https://crrev.com/03a4b5341796e1f014f6357a5a5ffcb5d0e76aba/chrome/browser/notifications/arc_notifier_manager.h
►

Sign in to add a comment