Pinch zoom via touchpad is not working. |
|||||||
Issue descriptionVersion: r399804 OS: OS X (10.11.5 MBP Retina 15", Mid 2015) What steps will reproduce the problem? (1) Open a zoomable page such as nytimes.com. (2) Pinch to zoom. What is the expected output? - Pinch zooming should work. What do you see instead? - No response to the input.
,
Jun 15 2016
Double-tap to zoom was working, but pinch-zoom not. I can confirm it is working on today's Canary 53.0.2768.0, so I'll try a new dev build.
,
Jun 16 2016
Pinch zoom is still not working in my local Release build. ccameron@ also confirmed.
,
Jun 16 2016
,
Jun 16 2016
,
Jun 20 2016
I just built top of tree on a MBP, and pinch zooming appears to be working fine. I'm happy to look into/bisect this problem if it's reproducible. ccameron@, maybe tomorrow when you're in MTV you can show me the problematic behavior?
,
Jun 20 2016
It's back to working on Canary for me. I'll verify a local build, then close if it's alive again.
,
Jul 21 2016
Does not work on touchscreen windows devices
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4480ddac51c6c5e195ca5a14f5ef35a27b9865a commit b4480ddac51c6c5e195ca5a14f5ef35a27b9865a Author: ananta <ananta@chromium.org> Date: Fri Jul 22 20:10:56 2016 Fix touchpad zoom on touchscreen Windows devices. TouchPad pinch to zoom on Windows typically works via a WM_MOUSEWHEEL message with the CONTROL flag in wParam and varying deltas. On touchscreen Windows devices like Surface, the WM_MOUSEWHEEL event is flagged as a synthesized message occurring due to a touch. I think it is safe to allow all WM_MOUSEWHEEL events to be processed by ignoring the touch flag as they don't appear to get synthesized via standard touch scrolls. Changes in this patch are as below: 1. Ignore the touch flag on WM_MOUSEWHEEL and WM_MOUSEHWHEEL messages. 2. Removed dead code in hwnd_message_handler.cc/.h which tried to set scroll styles on the window. BUG=620182 Review-Url: https://codereview.chromium.org/2172843002 Cr-Commit-Position: refs/heads/master@{#407240} [modify] https://crrev.com/b4480ddac51c6c5e195ca5a14f5ef35a27b9865a/ui/views/win/hwnd_message_handler.cc [modify] https://crrev.com/b4480ddac51c6c5e195ca5a14f5ef35a27b9865a/ui/views/win/hwnd_message_handler.h
,
Aug 11 2016
->ananta cause they are checking in changes on this. Mac issue can be closed.
,
Oct 17 2016
Able to reproduce on latest tree local build (r425759), Mac 10.11.6. Two finger pinch zoom doesn't work. However not able to reproduce on Canary 56.0.2891.0. Is this related to Official build or something?
,
Oct 25 2016
erik, can you repro in a local build? comment #12 seems bizarre.
,
Aug 12 2017
It seems this issue is related to the macOS SDK version. When Chromium is built with 10.10 SDK everything works fine, but then 10.12 is used — pinch zooming doesn't work anymore.
,
Aug 21
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tapted@chromium.org
, Jun 15 2016Labels: Needs-Feedback
Owner: erikc...@chromium.org
Status: Unconfirmed (was: Untriaged)