New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620162 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Synced tabs] When collapsing a section, bottom shadow is too thick

Project Member Reported by tbuck...@chromium.org, Jun 14 2016

Issue description

When collapsing a device section, the bottom border of the section header and the card shadow combine, making it look like a very large shadow.
 
Owner: tsergeant@chromium.org
Status: Assigned (was: Available)
Cc: lshang@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34b990b50b984c81eb660e8ceaf9c2d431c7aad6

commit 34b990b50b984c81eb660e8ceaf9c2d431c7aad6
Author: lshang <lshang@chromium.org>
Date: Mon Jul 25 08:10:09 2016

MD History: Fix bottom shadow of synced device card when collapsed

Currently for synced device cards, the #history-item-container has a 2px bottom
border, .card-title has a 1px bottom border and the collapse section has no
borders. In this way, the overall synced device card will have a 2px border at
bottom when opened, but will result in a 3px bottom border when the collapse
section is closed, which is too thick.

This CL changed #history-item-container's bottom border to be 1px only and let
collapse section to have a 1px border, so that no matter the collapse section is
opened or closed, the overall synced device card will always have a 2px bottom
border.

BUG= 620162 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2172143002
Cr-Commit-Position: refs/heads/master@{#407429}

[modify] https://crrev.com/34b990b50b984c81eb660e8ceaf9c2d431c7aad6/chrome/browser/resources/md_history/synced_device_card.html

Owner: lshang@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment