Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This is still reproduced when recently tested on M57 dev build.

I finally did a little digging on this; Pavel, could it be the result of http://crrev.com/2044003005?

The issue is not related to http://crrev.com/2044003005.

Displaying notification is triggered by SyncServiceObserver::OnStateChanged, the event that gets fired in a number of situations. The logic for displaying notification is in sync_error_notifier_ash.cc. Currently it shows notification if there is no active notification displayed (if previous notification was closed per repro steps). This means that if user dismissed notification and then opened sync settings they will get notification again.

I think we should only show notification once and only show next notification after next user login into chromeos account or if notification is related to different issue (user has entered passphrase and then changed it again from different client). Elias, do you think this behavior is better from UX perspective?

+1 to your suggestion. The notification should be showed once-per-login (unless it's a new error).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2870786bb6d391f0ee19f87a84f4278c95154fb0

commit 2870786bb6d391f0ee19f87a84f4278c95154fb0
Author: pavely <pavely@chromium.org>
Date: Mon Mar 27 23:40:48 2017

[Sync] Don't display passphrase notification if user dismissed previous one

The scenario:
- User gets notification to enter passphrase on ChromeOS, then dismisses it
- When user opens sync settings this notification is displayed again even though
  user intention is likely to enter passphrase.

The solution is not to display passphrase notification if user has dismissed
previous one. Notification will be displayed after user signs in into profile
and for any new passphrase (user entered previous one and then changed it again
from remote device).

BUG= 620133 
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2772783004
Cr-Commit-Position: refs/heads/master@{#459937}

[modify] https://crrev.com/2870786bb6d391f0ee19f87a84f4278c95154fb0/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/2870786bb6d391f0ee19f87a84f4278c95154fb0/chrome/browser/sync/sync_error_notifier_ash.h
[modify] https://crrev.com/2870786bb6d391f0ee19f87a84f4278c95154fb0/chrome/browser/sync/sync_error_notifier_ash_unittest.cc